Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623

[Aaron Ma <aaron.ma@canonical.com>]

On 10/24/19 6:35 PM, Takashi Iwai wrote:
> On Thu, 24 Oct 2019 09:20:19 +0200,
> Kailang wrote:
>>
>> Hi Takashi,
>>
>> Attach patch was support ALC623.
> 
> Thanks, applied now.
> 
> Aaron, could you rebase your patch and resubmit?
> 
> 

Yes I will.
One line of same changes.

Thanks,
Aaron

> Takashi
> 
>>
>> BR,
>> Kailang
>>
>>> -----Original Message-----
>>> From: Aaron Ma <aaron.ma@canonical.com>
>>> Sent: Wednesday, October 23, 2019 6:06 PM
>>> To: Kailang <kailang@realtek.com>; Takashi Iwai <tiwai@suse.de>
>>> Cc: perex@perex.cz; hui.wang@canonical.com; alsa-devel@alsa-project.org;
>>> linux-kernel@vger.kernel.org
>>> Subject: Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
>>>
>>> On 10/23/19 4:44 PM, Kailang wrote:
>>>>
>>>>
>>>>> -----Original Message-----
>>>>> From: Takashi Iwai <tiwai@suse.de>
>>>>> Sent: Wednesday, October 23, 2019 12:08 AM
>>>>> To: Aaron Ma <aaron.ma@canonical.com>
>>>>> Cc: perex@perex.cz; Kailang <kailang@realtek.com>;
>>>>> hui.wang@canonical.com; alsa-devel@alsa-project.org;
>>>>> linux-kernel@vger.kernel.org
>>>>> Subject: Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec
>>>>> 0x623
>>>>>
>>>>> On Tue, 22 Oct 2019 17:38:55 +0200,
>>>>> Aaron Ma wrote:
>>>>>>
>>>>>> These 2 ThinkCentres installed a new realtek codec ID 0x623, it has
>>>>>> 2 front mics with the same location on pin 0x18 and 0x19.
>>>>>>
>>>>>> Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic location
>>>>>> to right, then pulseaudio can handle them.
>>>>>> One "Front Mic" and one "Mic" will be shown, and audio output works
>>>>>> fine.
>>>>>>
>>>>>> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
>>>>>
>>>>> I'd like to have Kailang's review about the new codec before applying.
>>>>>
>>>>> Kailang, could you take a look?
>>>> OK.
>>>> I will post you the patch for ALC623 codec tomorrow.
>>>> Thanks.
>>>
>>> Cc me too.
>>>
>>> Thank you.
>>> Aaron
>>>
>>>>
>>>>>
>>>>>
>>>>> thanks,
>>>>>
>>>>> Takashi
>>>>>
>>>>>> ---
>>>>>>  sound/pci/hda/patch_realtek.c | 3 +++
>>>>>>  1 file changed, 3 insertions(+)
>>>>>>
>>>>>> diff --git a/sound/pci/hda/patch_realtek.c
>>>>>> b/sound/pci/hda/patch_realtek.c index b000b36ac3c6..c34d8b435f58
>>>>>> 100644
>>>>>> --- a/sound/pci/hda/patch_realtek.c
>>>>>> +++ b/sound/pci/hda/patch_realtek.c
>>>>>> @@ -7186,6 +7186,8 @@ static const struct snd_pci_quirk
>>>>>> alc269_fixup_tbl[]
>>>>> = {
>>>>>>  	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station",
>>>>> ALC294_FIXUP_LENOVO_MIC_LOCATION),
>>>>>>  	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station",
>>>>> ALC294_FIXUP_LENOVO_MIC_LOCATION),
>>>>>>  	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station",
>>>>>> ALC283_FIXUP_HEADSET_MIC),
>>>>>> +	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station",
>>>>> ALC283_FIXUP_HEADSET_MIC),
>>>>>> +	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station",
>>>>>> +ALC283_FIXUP_HEADSET_MIC),
>>>>>>  	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80",
>>>>> ALC269_FIXUP_DMIC_THINKPAD_ACPI),
>>>>>>  	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210",
>>>>> ALC283_FIXUP_INT_MIC),
>>>>>>  	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70",
>>>>>> ALC269_FIXUP_DMIC_THINKPAD_ACPI), @@ -9187,6 +9189,7 @@ static
>>>>> const struct hda_device_id snd_hda_id_realtek[] = {
>>>>>>  	HDA_CODEC_ENTRY(0x10ec0298, "ALC298", patch_alc269),
>>>>>>  	HDA_CODEC_ENTRY(0x10ec0299, "ALC299", patch_alc269),
>>>>>>  	HDA_CODEC_ENTRY(0x10ec0300, "ALC300", patch_alc269),
>>>>>> +	HDA_CODEC_ENTRY(0x10ec0623, "ALC623", patch_alc269),
>>>>>>  	HDA_CODEC_REV_ENTRY(0x10ec0861, 0x100340, "ALC660",
>>>>> patch_alc861),
>>>>>>  	HDA_CODEC_ENTRY(0x10ec0660, "ALC660-VD", patch_alc861vd),
>>>>>>  	HDA_CODEC_ENTRY(0x10ec0861, "ALC861", patch_alc861),
>>>>>> --
>>>>>> 2.17.1
>>>>>>
>>>>>
>>>>> ------Please consider the environment before printing this e-mail.
>> [2 0000-add-support-alc623.patch <application/octet-stream (base64)>]
>>