[PATCH] hwrng: omap - Delete an error message in of_get_omap_rng_device_details()

[PATCH] hwrng: omap - Delete an error message in of_get_omap_rng_device_details()

[Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 4 Apr 2020 16:45:57 +0200

The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/char/hw_random/omap-rng.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/omap-rng.c
index 65952393e1bb..7290c603fcb8 100644
--- a/drivers/char/hw_random/omap-rng.c
+++ b/drivers/char/hw_random/omap-rng.c
@@ -392,11 +392,8 @@ static int of_get_omap_rng_device_details(struct omap_rng_dev *priv,
 	if (of_device_is_compatible(dev->of_node, "ti,omap4-rng") ||
 	    of_device_is_compatible(dev->of_node, "inside-secure,safexcel-eip76")) {
 		irq = platform_get_irq(pdev, 0);
-		if (irq < 0) {
-			dev_err(dev, "%s: error getting IRQ resource - %d\n",
-				__func__, irq);
+		if (irq < 0)
 			return irq;
-		}

 		err = devm_request_irq(dev, irq, omap4_rng_irq,
 				       IRQF_TRIGGER_NONE, dev_name(dev), priv);
--
2.26.0

Re: hwrng: omap - Delete an error message in of_get_omap_rng_device_details()

[Markus Elfring]

> I don't know why you always cc me in your patch
> which is similar type  I have submitted。

I noticed your selection of possible changes (and corresponding patch reviews).

* Thus I assumed that you are interested in further software evolution
  to some degree in such a design direction.
  Do you want that I omit your mail address from my patches?

* I picked also a few of your change ideas up for their application
  together with development tools I am familiar with.


> Let me study

I hope so.


> to thank you ?

This possibility can also be occasionally nice.


> You are a senior,

Such a view might be appropriate.


> I have thanked you for your instruction,

I hope that our collaboration will evolve further in constructive ways.


> and I have understand what your question:

Would we like to achieve a better common understanding?


> How do you think about to change any more source files in a systematic way?

Advanced source code analysis can point several update candidates out.
An execution of a script for the semantic patch language (Coccinelle software)
indicates change possibilities around calls of the function “platform_get_irq”
in 74 source files of the software “Linux next-20200402” at the moment.
Source code search patterns can be extended after some clarification.

Regards,
Markus

Re: Clarification for software development opportunities

[Markus Elfring]

> I don't know what is Coccinelle software, I will check it out.

I am curious under which circumstances the development tool box will be adjusted.
http://coccinelle.lip6.fr/


> When I receive critical emails from others, I am happy that this is my study plan.

This view sounds positive.


> Previously, I was happy and looking forward to providing patches to the community.

Such feedback is nice.


> But when I noticed that you were sending similar patches over and over again,

This can be an usual effect from the application of known source code
analysis approaches.


> I realized that if I want to increase my patch count,

I suggest to reconsider corresponding development goals.


> I would not be able to reuse some files I had already found,

This can occasionally happen when some contributors try to achieve something
in similar areas.

* Would you like to clarify opportunities for further contributions?

* Do you find globally distributed collaboration interesting?


> which made me sad.

* I find your feeling unfortunate.

* I hope that your view can become more positive again.


> So,thank you for giving me a lesson.

This was eventually my intention partly.

I imagine that possibilities can be improved also for teaching and education.

Regards,
Markus

Re: hwrng: omap - Delete an error message in of_get_omap_rng_device_details()

[Markus Elfring]

> I don't know what is Coccinelle software, I will check it out.

I suggest to take another look at corresponding software development possibilities.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/scripts/coccinelle/api/platform_get_irq.cocci

Do you find any information from previous clarification attempts interesting?
Commit 7723f4c5ecdb8d832f049f8483beb0d1081cedf6
("driver core: platform: Add an error message to platform_get_irq*()"
by Stephen Boyd on 2019-07-29)

Are you looking for further collateral evolution?

Regards,
Markus

Re: [PATCH] hwrng: omap - Delete an error message in of_get_omap_rng_device_details()

[Herbert Xu]

On Sat, Apr 04, 2020 at 04:56:57PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 4 Apr 2020 16:45:57 +0200
> 
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/char/hw_random/omap-rng.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt