* [PATCH -next] erofs: modify the error message when prepare_ondemand_read failed
@ 2024-04-24 8:42 Hongbo Li
2024-04-24 11:21 ` Jingbo Xu
2024-04-28 6:23 ` Chao Yu
0 siblings, 2 replies; 5+ messages in thread
From: Hongbo Li @ 2024-04-24 8:42 UTC (permalink / raw)
To: xiang, chao
Cc: huyue2, jefflexu, dhavale, linux-erofs, linux-kernel, lihongbo22
When prepare_ondemand_read failed, wrong error message is printed.
The prepare_read is also implemented in cachefiles, so we amend it.
Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
---
fs/erofs/fscache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
index 8aff1a724805..62da538d91cb 100644
--- a/fs/erofs/fscache.c
+++ b/fs/erofs/fscache.c
@@ -151,7 +151,7 @@ static int erofs_fscache_read_io_async(struct fscache_cookie *cookie,
if (WARN_ON(len == 0))
source = NETFS_INVALID_READ;
if (source != NETFS_READ_FROM_CACHE) {
- erofs_err(NULL, "prepare_read failed (source %d)", source);
+ erofs_err(NULL, "prepare_ondemand_read failed (source %d)", source);
return -EIO;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH -next] erofs: modify the error message when prepare_ondemand_read failed
2024-04-24 8:42 [PATCH -next] erofs: modify the error message when prepare_ondemand_read failed Hongbo Li
@ 2024-04-24 11:21 ` Jingbo Xu
2024-04-28 6:23 ` Chao Yu
1 sibling, 0 replies; 5+ messages in thread
From: Jingbo Xu @ 2024-04-24 11:21 UTC (permalink / raw)
To: Hongbo Li, xiang, chao; +Cc: huyue2, dhavale, linux-erofs, linux-kernel
On 4/24/24 4:42 PM, Hongbo Li wrote:
> When prepare_ondemand_read failed, wrong error message is printed.
> The prepare_read is also implemented in cachefiles, so we amend it.
>
> Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
> ---
> fs/erofs/fscache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
> index 8aff1a724805..62da538d91cb 100644
> --- a/fs/erofs/fscache.c
> +++ b/fs/erofs/fscache.c
> @@ -151,7 +151,7 @@ static int erofs_fscache_read_io_async(struct fscache_cookie *cookie,
> if (WARN_ON(len == 0))
> source = NETFS_INVALID_READ;
> if (source != NETFS_READ_FROM_CACHE) {
> - erofs_err(NULL, "prepare_read failed (source %d)", source);
> + erofs_err(NULL, "prepare_ondemand_read failed (source %d)", source);
> return -EIO;
> }
>
LGTM.
Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
--
Thanks,
Jingbo
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] erofs: modify the error message when prepare_ondemand_read failed
2024-04-24 8:42 [PATCH -next] erofs: modify the error message when prepare_ondemand_read failed Hongbo Li
2024-04-24 11:21 ` Jingbo Xu
@ 2024-04-28 6:23 ` Chao Yu
1 sibling, 0 replies; 5+ messages in thread
From: Chao Yu @ 2024-04-28 6:23 UTC (permalink / raw)
To: Hongbo Li, xiang; +Cc: huyue2, jefflexu, dhavale, linux-erofs, linux-kernel
On 2024/4/24 16:42, Hongbo Li wrote:
> When prepare_ondemand_read failed, wrong error message is printed.
> The prepare_read is also implemented in cachefiles, so we amend it.
>
> Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20240424023945.420828-1-lihongbo22@huawei.com>]
* Re: [PATCH -next] erofs: modify the error message when prepare_ondemand_read failed
[not found] <20240424023945.420828-1-lihongbo22@huawei.com>
@ 2024-04-24 3:29 ` Gao Xiang
2024-04-24 8:44 ` Hongbo Li
0 siblings, 1 reply; 5+ messages in thread
From: Gao Xiang @ 2024-04-24 3:29 UTC (permalink / raw)
To: Hongbo Li, xiang, chao
Cc: huyue2, jefflexu, dhavale, linux-erofs mailing list, LKML
(+cc linux-erofs & LKML)
On 2024/4/24 10:39, Hongbo Li wrote:
> When prepare_ondemand_read failed, wrong error message is printed.
> The prepare_read is also implemented in cachefiles, so we amend it.
>
> Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Could you resend the patch with proper mailing list cced with my
"reviewed-by:" tag? So I could apply with "b4" tool.
Thanks,
Gao Xiang
> ---
> fs/erofs/fscache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
> index 8aff1a724805..62da538d91cb 100644
> --- a/fs/erofs/fscache.c
> +++ b/fs/erofs/fscache.c
> @@ -151,7 +151,7 @@ static int erofs_fscache_read_io_async(struct fscache_cookie *cookie,
> if (WARN_ON(len == 0))
> source = NETFS_INVALID_READ;
> if (source != NETFS_READ_FROM_CACHE) {
> - erofs_err(NULL, "prepare_read failed (source %d)", source);
> + erofs_err(NULL, "prepare_ondemand_read failed (source %d)", source);
> return -EIO;
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] erofs: modify the error message when prepare_ondemand_read failed
2024-04-24 3:29 ` Gao Xiang
@ 2024-04-24 8:44 ` Hongbo Li
0 siblings, 0 replies; 5+ messages in thread
From: Hongbo Li @ 2024-04-24 8:44 UTC (permalink / raw)
To: Gao Xiang, xiang, chao
Cc: huyue2, jefflexu, dhavale, linux-erofs mailing list, LKML
ok, thanks!
On 2024/4/24 11:29, Gao Xiang wrote:
>
> (+cc linux-erofs & LKML)
>
> On 2024/4/24 10:39, Hongbo Li wrote:
>> When prepare_ondemand_read failed, wrong error message is printed.
>> The prepare_read is also implemented in cachefiles, so we amend it.
>>
>> Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
>
> Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
>
> Could you resend the patch with proper mailing list cced with my
> "reviewed-by:" tag? So I could apply with "b4" tool.
>
> Thanks,
> Gao Xiang
>
>> ---
>> fs/erofs/fscache.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
>> index 8aff1a724805..62da538d91cb 100644
>> --- a/fs/erofs/fscache.c
>> +++ b/fs/erofs/fscache.c
>> @@ -151,7 +151,7 @@ static int erofs_fscache_read_io_async(struct
>> fscache_cookie *cookie,
>> if (WARN_ON(len == 0))
>> source = NETFS_INVALID_READ;
>> if (source != NETFS_READ_FROM_CACHE) {
>> - erofs_err(NULL, "prepare_read failed (source %d)", source);
>> + erofs_err(NULL, "prepare_ondemand_read failed (source
>> %d)", source);
>> return -EIO;
>> }
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-04-28 6:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-24 8:42 [PATCH -next] erofs: modify the error message when prepare_ondemand_read failed Hongbo Li
2024-04-24 11:21 ` Jingbo Xu
2024-04-28 6:23 ` Chao Yu
[not found] <20240424023945.420828-1-lihongbo22@huawei.com>
2024-04-24 3:29 ` Gao Xiang
2024-04-24 8:44 ` Hongbo Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox