From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>, Lee Jones <lee@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mfd: rohm-bd718x7: Use software nodes for gpio-keys
Date: Tue, 24 Mar 2026 08:47:41 +0200 [thread overview]
Message-ID: <e98e03d8-288e-41bb-a688-24e24c5d9b7e@gmail.com> (raw)
In-Reply-To: <20260322-rohm-software-nodes-v2-2-3c7d21336d37@gmail.com>
On 23/03/2026 03:37, Dmitry Torokhov wrote:
> Refactor the rohm-bd7182x7 MFD driver to use software nodes for
> instantiating the gpio-keys child device, replacing the old
> platform_data mechanism.
>
> The power key's properties are now defined using software nodes and
> property entries. The IRQ is passed as a resource attached to the
> platform device.
>
> This will allow dropping support for using platform data for configuring
> gpio-keys in the future.
I think we miss Signed-off-by -line here. Other than that, similar
comments as I had for the 1/2.
Yours,
-- Matti
---
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
prev parent reply other threads:[~2026-03-24 6:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 1:37 [PATCH v2 0/2] rohm-bdi718x7/71828: Use software nodes for gpio-keys Dmitry Torokhov
2026-03-23 1:37 ` [PATCH v2 1/2] mfd: rohm-bd71828: " Dmitry Torokhov
2026-03-24 6:45 ` Matti Vaittinen
2026-03-25 0:34 ` Dmitry Torokhov
2026-03-23 1:37 ` [PATCH v2 2/2] mfd: rohm-bd718x7: " Dmitry Torokhov
2026-03-24 6:47 ` Matti Vaittinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e98e03d8-288e-41bb-a688-24e24c5d9b7e@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox