* [PATCH] net: ti: icssg-prueth: add PTP_1588_CLOCK_OPTIONAL dependency
@ 2025-12-04 10:01 Arnd Bergmann
2025-12-05 0:12 ` Vadim Fedorenko
2025-12-10 9:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2025-12-04 10:01 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Richard Cochran, MD Danish Anwar, Diogo Ivo,
Jan Kiszka, Roger Quadros, Basharath Hussain Khaja,
Andrew F. Davis, Parvathi Pudi
Cc: Arnd Bergmann, Meghana Malladi, Sascha Hauer, Mohan Reddy Putluru,
netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The new icssg-prueth driver needs the same dependency as the other parts
that use the ptp-1588:
WARNING: unmet direct dependencies detected for TI_ICSS_IEP
Depends on [m]: NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_TI [=y] && PTP_1588_CLOCK_OPTIONAL [=m] && TI_PRUSS [=y]
Selected by [y]:
- TI_PRUETH [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_TI [=y] && PRU_REMOTEPROC [=y] && NET_SWITCHDEV [=y]
Add the correct dependency on the two drivers missing it, and remove
the pointless 'imply' in the process.
Fixes: e654b85a693e ("net: ti: icssg-prueth: Add ICSSG Ethernet driver for AM65x SR1.0 platforms")
Fixes: 511f6c1ae093 ("net: ti: icssm-prueth: Adds ICSSM Ethernet driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/ti/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
index a54d71155263..fe5b2926d8ab 100644
--- a/drivers/net/ethernet/ti/Kconfig
+++ b/drivers/net/ethernet/ti/Kconfig
@@ -209,6 +209,7 @@ config TI_ICSSG_PRUETH_SR1
depends on PRU_REMOTEPROC
depends on NET_SWITCHDEV
depends on ARCH_K3 && OF && TI_K3_UDMA_GLUE_LAYER
+ depends on PTP_1588_CLOCK_OPTIONAL
help
Support dual Gigabit Ethernet ports over the ICSSG PRU Subsystem.
This subsystem is available on the AM65 SR1.0 platform.
@@ -234,7 +235,7 @@ config TI_PRUETH
depends on PRU_REMOTEPROC
depends on NET_SWITCHDEV
select TI_ICSS_IEP
- imply PTP_1588_CLOCK
+ depends on PTP_1588_CLOCK_OPTIONAL
help
Some TI SoCs has Programmable Realtime Unit (PRU) cores which can
support Single or Dual Ethernet ports with the help of firmware code
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: ti: icssg-prueth: add PTP_1588_CLOCK_OPTIONAL dependency
2025-12-04 10:01 [PATCH] net: ti: icssg-prueth: add PTP_1588_CLOCK_OPTIONAL dependency Arnd Bergmann
@ 2025-12-05 0:12 ` Vadim Fedorenko
2025-12-10 9:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Vadim Fedorenko @ 2025-12-05 0:12 UTC (permalink / raw)
To: Arnd Bergmann, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Richard Cochran, MD Danish Anwar,
Diogo Ivo, Jan Kiszka, Roger Quadros, Basharath Hussain Khaja,
Andrew F. Davis, Parvathi Pudi
Cc: Arnd Bergmann, Meghana Malladi, Sascha Hauer, Mohan Reddy Putluru,
netdev, linux-kernel
On 04/12/2025 10:01, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The new icssg-prueth driver needs the same dependency as the other parts
> that use the ptp-1588:
>
> WARNING: unmet direct dependencies detected for TI_ICSS_IEP
> Depends on [m]: NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_TI [=y] && PTP_1588_CLOCK_OPTIONAL [=m] && TI_PRUSS [=y]
> Selected by [y]:
> - TI_PRUETH [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_TI [=y] && PRU_REMOTEPROC [=y] && NET_SWITCHDEV [=y]
>
> Add the correct dependency on the two drivers missing it, and remove
> the pointless 'imply' in the process.
>
> Fixes: e654b85a693e ("net: ti: icssg-prueth: Add ICSSG Ethernet driver for AM65x SR1.0 platforms")
> Fixes: 511f6c1ae093 ("net: ti: icssm-prueth: Adds ICSSM Ethernet driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ethernet/ti/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
> index a54d71155263..fe5b2926d8ab 100644
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -209,6 +209,7 @@ config TI_ICSSG_PRUETH_SR1
> depends on PRU_REMOTEPROC
> depends on NET_SWITCHDEV
> depends on ARCH_K3 && OF && TI_K3_UDMA_GLUE_LAYER
> + depends on PTP_1588_CLOCK_OPTIONAL
> help
> Support dual Gigabit Ethernet ports over the ICSSG PRU Subsystem.
> This subsystem is available on the AM65 SR1.0 platform.
> @@ -234,7 +235,7 @@ config TI_PRUETH
> depends on PRU_REMOTEPROC
> depends on NET_SWITCHDEV
> select TI_ICSS_IEP
> - imply PTP_1588_CLOCK
> + depends on PTP_1588_CLOCK_OPTIONAL
> help
> Some TI SoCs has Programmable Realtime Unit (PRU) cores which can
> support Single or Dual Ethernet ports with the help of firmware code
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: ti: icssg-prueth: add PTP_1588_CLOCK_OPTIONAL dependency
2025-12-04 10:01 [PATCH] net: ti: icssg-prueth: add PTP_1588_CLOCK_OPTIONAL dependency Arnd Bergmann
2025-12-05 0:12 ` Vadim Fedorenko
@ 2025-12-10 9:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-12-10 9:20 UTC (permalink / raw)
To: Arnd Bergmann
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, richardcochran,
danishanwar, diogo.ivo, jan.kiszka, rogerq, basharath, afd,
parvathi, arnd, m-malladi, s.hauer, pmohan, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 4 Dec 2025 11:01:28 +0100 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The new icssg-prueth driver needs the same dependency as the other parts
> that use the ptp-1588:
>
> WARNING: unmet direct dependencies detected for TI_ICSS_IEP
> Depends on [m]: NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_TI [=y] && PTP_1588_CLOCK_OPTIONAL [=m] && TI_PRUSS [=y]
> Selected by [y]:
> - TI_PRUETH [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_TI [=y] && PRU_REMOTEPROC [=y] && NET_SWITCHDEV [=y]
>
> [...]
Here is the summary with links:
- net: ti: icssg-prueth: add PTP_1588_CLOCK_OPTIONAL dependency
https://git.kernel.org/netdev/net/c/9e7477a42744
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-10 9:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-04 10:01 [PATCH] net: ti: icssg-prueth: add PTP_1588_CLOCK_OPTIONAL dependency Arnd Bergmann
2025-12-05 0:12 ` Vadim Fedorenko
2025-12-10 9:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox