public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: Changwoo Min <changwoo@igalia.com>
Cc: christian.loehle@arm.com, tj@kernel.org, pavel@kernel.org,
	len.brown@intel.com, rafael@kernel.org, kernel-dev@igalia.com,
	linux-pm@vger.kernel.org, sched-ext@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v4 10/10] PM: EM: Notify an event when the performance domain changes
Date: Fri, 10 Oct 2025 11:20:40 +0100	[thread overview]
Message-ID: <eba311e7-2c8f-4c74-a065-17a12ee29bf8@arm.com> (raw)
In-Reply-To: <20250921031928.205869-11-changwoo@igalia.com>



On 9/21/25 04:19, Changwoo Min wrote:
> Send an event to userspace when a performance domain is created or deleted,
> or its energy model is updated.
> 
> Signed-off-by: Changwoo Min <changwoo@igalia.com>
> ---
>   kernel/power/energy_model.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c
> index 740076d24479..fca32d1c6661 100644
> --- a/kernel/power/energy_model.c
> +++ b/kernel/power/energy_model.c
> @@ -17,6 +17,8 @@
>   #include <linux/sched/topology.h>
>   #include <linux/slab.h>
>   
> +#include "em_netlink.h"
> +
>   /*
>    * Mutex serializing the registrations of performance domains and letting
>    * callbacks defined by drivers sleep.
> @@ -350,6 +352,8 @@ int em_dev_update_perf_domain(struct device *dev,
>   	em_table_free(old_table);
>   
>   	mutex_unlock(&em_pd_mutex);
> +
> +	em_notify_pd_updated(pd);
>   	return 0;
>   }
>   EXPORT_SYMBOL_GPL(em_dev_update_perf_domain);
> @@ -697,6 +701,7 @@ int em_dev_register_pd_no_update(struct device *dev, unsigned int nr_states,
>   	list_add_tail(&dev->em_pd->node, &em_pd_list);
>   	mutex_unlock(&em_pd_list_mutex);
>   
> +	em_notify_pd_created(dev->em_pd);
>   	return ret;
>   }
>   EXPORT_SYMBOL_GPL(em_dev_register_pd_no_update);
> @@ -719,6 +724,8 @@ void em_dev_unregister_perf_domain(struct device *dev)
>   	list_del_init(&dev->em_pd->node);
>   	mutex_unlock(&em_pd_list_mutex);
>   
> +	em_notify_pd_deleted(dev->em_pd);
> +
>   	/*
>   	 * The mutex separates all register/unregister requests and protects
>   	 * from potential clean-up/setup issues in the debugfs directories.

LGTM,

Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>

      reply	other threads:[~2025-10-10 10:20 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-21  3:19 [PATCH RESEND v4 00/10] PM: EM: Add netlink support for the energy model Changwoo Min
2025-09-21  3:19 ` [PATCH RESEND v4 01/10] PM: EM: Assign a unique ID when creating a performance domain Changwoo Min
2025-10-06  8:17   ` Lukasz Luba
2025-10-06 12:24     ` Lukasz Luba
2025-10-13 13:46       ` Changwoo Min
2025-09-21  3:19 ` [PATCH RESEND v4 02/10] PM: EM: Expose the ID of a performance domain via debugfs Changwoo Min
2025-10-06 14:26   ` Lukasz Luba
2025-09-21  3:19 ` [PATCH RESEND v4 03/10] PM: EM: Add an iterator and accessor for the performance domain Changwoo Min
2025-10-06 15:14   ` Lukasz Luba
2025-09-21  3:19 ` [PATCH RESEND v4 04/10] PM: EM: Add em.yaml and autogen files Changwoo Min
2025-10-06 15:25   ` Lukasz Luba
2025-09-21  3:19 ` [PATCH RESEND v4 05/10] PM: EM: Add a skeleton code for netlink notification Changwoo Min
2025-10-06 15:44   ` Lukasz Luba
2025-10-13 13:46     ` Changwoo Min
2025-10-13 13:53       ` Lukasz Luba
2025-10-13 14:43         ` Changwoo Min
2025-09-21  3:19 ` [PATCH RESEND v4 06/10] PM: EM: Implement em_nl_get_pds_doit() Changwoo Min
2025-10-10  9:32   ` Lukasz Luba
2025-09-21  3:19 ` [PATCH RESEND v4 07/10] PM: EM: Implement em_nl_get_pd_table_doit() Changwoo Min
2025-10-10 10:01   ` Lukasz Luba
2025-10-13 13:47     ` Changwoo Min
2025-09-21  3:19 ` [PATCH RESEND v4 08/10] PM: EM: Implement em_notify_pd_deleted() Changwoo Min
2025-10-10 10:17   ` Lukasz Luba
2025-09-21  3:19 ` [PATCH RESEND v4 09/10] PM: EM: Implement em_notify_pd_created/updated() Changwoo Min
2025-10-10 10:19   ` Lukasz Luba
2025-09-21  3:19 ` [PATCH RESEND v4 10/10] PM: EM: Notify an event when the performance domain changes Changwoo Min
2025-10-10 10:20   ` Lukasz Luba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eba311e7-2c8f-4c74-a065-17a12ee29bf8@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=changwoo@igalia.com \
    --cc=christian.loehle@arm.com \
    --cc=kernel-dev@igalia.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@kernel.org \
    --cc=rafael@kernel.org \
    --cc=sched-ext@lists.linux.dev \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox