* [PATCH] Documentation: riscv: cmodx: fix typos
@ 2026-04-29 22:35 Avi Radinsky
2026-04-29 22:38 ` Randy Dunlap
2026-04-30 20:08 ` Paul Walmsley
0 siblings, 2 replies; 3+ messages in thread
From: Avi Radinsky @ 2026-04-29 22:35 UTC (permalink / raw)
To: palmer, pjw, aou, alex, corbet
Cc: linux-riscv, linux-doc, linux-kernel, avi.radinsky
Fix typos in the dynamic ftrace section: atmoic -> atomic (twice),
pacthable -> patchable, derect -> directed.
Signed-off-by: Avi Radinsky <avi.radinsky@tennr.com>
---
Documentation/arch/riscv/cmodx.rst | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/arch/riscv/cmodx.rst b/Documentation/arch/riscv/cmodx.rst
index 40ba53bed..cbfa812a1 100644
--- a/Documentation/arch/riscv/cmodx.rst
+++ b/Documentation/arch/riscv/cmodx.rst
@@ -21,13 +21,13 @@ call at each patchable function entry, and patches it dynamically at runtime to
enable or disable the redirection. In the case of RISC-V, 2 instructions,
AUIPC + JALR, are required to compose a function call. However, it is impossible
to patch 2 instructions and expect that a concurrent read-side executes them
-without a race condition. This series makes atmoic code patching possible in
+without a race condition. This series makes atomic code patching possible in
RISC-V ftrace. Kernel preemption makes things even worse as it allows the old
state to persist across the patching process with stop_machine().
In order to get rid of stop_machine() and run dynamic ftrace with full kernel
preemption, we partially initialize each patchable function entry at boot-time,
-setting the first instruction to AUIPC, and the second to NOP. Now, atmoic
+setting the first instruction to AUIPC, and the second to NOP. Now, atomic
patching is possible because the kernel only has to update one instruction.
According to Ziccif, as long as an instruction is naturally aligned, the ISA
guarantee an atomic update.
@@ -36,8 +36,8 @@ By fixing down the first instruction, AUIPC, the range of the ftrace trampoline
is limited to +-2K from the predetermined target, ftrace_caller, due to the lack
of immediate encoding space in RISC-V. To address the issue, we introduce
CALL_OPS, where an 8B naturally align metadata is added in front of each
-pacthable function. The metadata is resolved at the first trampoline, then the
-execution can be derect to another custom trampoline.
+patchable function. The metadata is resolved at the first trampoline, then the
+execution can be directed to another custom trampoline.
CMODX in the User Space
-----------------------
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: riscv: cmodx: fix typos
2026-04-29 22:35 [PATCH] Documentation: riscv: cmodx: fix typos Avi Radinsky
@ 2026-04-29 22:38 ` Randy Dunlap
2026-04-30 20:08 ` Paul Walmsley
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2026-04-29 22:38 UTC (permalink / raw)
To: Avi Radinsky, palmer, pjw, aou, alex, corbet
Cc: linux-riscv, linux-doc, linux-kernel
On 4/29/26 3:35 PM, Avi Radinsky wrote:
> Fix typos in the dynamic ftrace section: atmoic -> atomic (twice),
> pacthable -> patchable, derect -> directed.
>
> Signed-off-by: Avi Radinsky <avi.radinsky@tennr.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> Documentation/arch/riscv/cmodx.rst | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/arch/riscv/cmodx.rst b/Documentation/arch/riscv/cmodx.rst
> index 40ba53bed..cbfa812a1 100644
> --- a/Documentation/arch/riscv/cmodx.rst
> +++ b/Documentation/arch/riscv/cmodx.rst
> @@ -21,13 +21,13 @@ call at each patchable function entry, and patches it dynamically at runtime to
> enable or disable the redirection. In the case of RISC-V, 2 instructions,
> AUIPC + JALR, are required to compose a function call. However, it is impossible
> to patch 2 instructions and expect that a concurrent read-side executes them
> -without a race condition. This series makes atmoic code patching possible in
> +without a race condition. This series makes atomic code patching possible in
> RISC-V ftrace. Kernel preemption makes things even worse as it allows the old
> state to persist across the patching process with stop_machine().
>
> In order to get rid of stop_machine() and run dynamic ftrace with full kernel
> preemption, we partially initialize each patchable function entry at boot-time,
> -setting the first instruction to AUIPC, and the second to NOP. Now, atmoic
> +setting the first instruction to AUIPC, and the second to NOP. Now, atomic
> patching is possible because the kernel only has to update one instruction.
> According to Ziccif, as long as an instruction is naturally aligned, the ISA
> guarantee an atomic update.
> @@ -36,8 +36,8 @@ By fixing down the first instruction, AUIPC, the range of the ftrace trampoline
> is limited to +-2K from the predetermined target, ftrace_caller, due to the lack
> of immediate encoding space in RISC-V. To address the issue, we introduce
> CALL_OPS, where an 8B naturally align metadata is added in front of each
> -pacthable function. The metadata is resolved at the first trampoline, then the
> -execution can be derect to another custom trampoline.
> +patchable function. The metadata is resolved at the first trampoline, then the
> +execution can be directed to another custom trampoline.
>
> CMODX in the User Space
> -----------------------
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: riscv: cmodx: fix typos
2026-04-29 22:35 [PATCH] Documentation: riscv: cmodx: fix typos Avi Radinsky
2026-04-29 22:38 ` Randy Dunlap
@ 2026-04-30 20:08 ` Paul Walmsley
1 sibling, 0 replies; 3+ messages in thread
From: Paul Walmsley @ 2026-04-30 20:08 UTC (permalink / raw)
To: Avi Radinsky
Cc: palmer, pjw, aou, alex, corbet, linux-riscv, linux-doc,
linux-kernel
On Wed, 29 Apr 2026, Avi Radinsky wrote:
> Fix typos in the dynamic ftrace section: atmoic -> atomic (twice),
> pacthable -> patchable, derect -> directed.
>
> Signed-off-by: Avi Radinsky <avi.radinsky@tennr.com>
Thanks, queued for v7.1-rc.
- Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-30 20:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-29 22:35 [PATCH] Documentation: riscv: cmodx: fix typos Avi Radinsky
2026-04-29 22:38 ` Randy Dunlap
2026-04-30 20:08 ` Paul Walmsley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox