* [PATCH] workqueue: Remove unused assert_rcu_or_wq_mutex_or_pool_mutex
@ 2025-11-10 1:26 zhangjiao2
2025-11-10 4:09 ` Lai Jiangshan
2025-11-10 16:15 ` Tejun Heo
0 siblings, 2 replies; 3+ messages in thread
From: zhangjiao2 @ 2025-11-10 1:26 UTC (permalink / raw)
To: tj; +Cc: linux-kernel, jiangshanlai, lkml, zhang jiao
From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
assert_rcu_or_wq_mutex_or_pool_mutex is never referenced in the code.
Just remove it.
Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
---
kernel/workqueue.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index c6b79b3675c3..a86889d8218b 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -539,12 +539,6 @@ static void show_one_worker_pool(struct worker_pool *pool);
!lockdep_is_held(&wq_pool_mutex), \
"RCU or wq_pool_mutex should be held")
-#define assert_rcu_or_wq_mutex_or_pool_mutex(wq) \
- RCU_LOCKDEP_WARN(!rcu_read_lock_any_held() && \
- !lockdep_is_held(&wq->mutex) && \
- !lockdep_is_held(&wq_pool_mutex), \
- "RCU, wq->mutex or wq_pool_mutex should be held")
-
#define for_each_bh_worker_pool(pool, cpu) \
for ((pool) = &per_cpu(bh_worker_pools, cpu)[0]; \
(pool) < &per_cpu(bh_worker_pools, cpu)[NR_STD_WORKER_POOLS]; \
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] workqueue: Remove unused assert_rcu_or_wq_mutex_or_pool_mutex
2025-11-10 1:26 [PATCH] workqueue: Remove unused assert_rcu_or_wq_mutex_or_pool_mutex zhangjiao2
@ 2025-11-10 4:09 ` Lai Jiangshan
2025-11-10 16:15 ` Tejun Heo
1 sibling, 0 replies; 3+ messages in thread
From: Lai Jiangshan @ 2025-11-10 4:09 UTC (permalink / raw)
To: zhangjiao2; +Cc: tj, linux-kernel, lkml
Hello,
On Mon, Nov 10, 2025 at 9:26 AM zhangjiao2
<zhangjiao2@cmss.chinamobile.com> wrote:
>
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
>
> assert_rcu_or_wq_mutex_or_pool_mutex is never referenced in the code.
> Just remove it.
>
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> ---
> kernel/workqueue.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index c6b79b3675c3..a86889d8218b 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -539,12 +539,6 @@ static void show_one_worker_pool(struct worker_pool *pool);
> !lockdep_is_held(&wq_pool_mutex), \
> "RCU or wq_pool_mutex should be held")
>
> -#define assert_rcu_or_wq_mutex_or_pool_mutex(wq) \
> - RCU_LOCKDEP_WARN(!rcu_read_lock_any_held() && \
> - !lockdep_is_held(&wq->mutex) && \
> - !lockdep_is_held(&wq_pool_mutex), \
> - "RCU, wq->mutex or wq_pool_mutex should be held")
> -
Reviewed-by: Lai Jiangshan <jiangshanlai@gmail.com>
Thanks
Lai
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] workqueue: Remove unused assert_rcu_or_wq_mutex_or_pool_mutex
2025-11-10 1:26 [PATCH] workqueue: Remove unused assert_rcu_or_wq_mutex_or_pool_mutex zhangjiao2
2025-11-10 4:09 ` Lai Jiangshan
@ 2025-11-10 16:15 ` Tejun Heo
1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2025-11-10 16:15 UTC (permalink / raw)
To: zhang jiao; +Cc: linux-kernel, jiangshanlai, lkml
Applied to wq/for-6.19.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-10 16:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-10 1:26 [PATCH] workqueue: Remove unused assert_rcu_or_wq_mutex_or_pool_mutex zhangjiao2
2025-11-10 4:09 ` Lai Jiangshan
2025-11-10 16:15 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox