* [PATCH v2] drm/xe/irq: Remove unnecessary semicolon in pick_engine_gt()
@ 2024-04-15 7:07 Jiapeng Chong
2024-04-15 10:13 ` Chauhan, Shekhar
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2024-04-15 7:07 UTC (permalink / raw)
To: lucas.demarchi
Cc: ogabbay, thomas.hellstrom, maarten.lankhorst, mripard,
tzimmermann, airlied, daniel, intel-xe, dri-devel, linux-kernel,
Jiapeng Chong, Abaci Robot
No functional modification involved.
./drivers/gpu/drm/xe/xe_irq.c:279:3-4: Unneeded semicolon.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8757
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
Changes in v2:
-Make the commit message more clearer.
drivers/gpu/drm/xe/xe_irq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
index 996806353171..5b1a2f46a1b2 100644
--- a/drivers/gpu/drm/xe/xe_irq.c
+++ b/drivers/gpu/drm/xe/xe_irq.c
@@ -276,7 +276,7 @@ static struct xe_gt *pick_engine_gt(struct xe_tile *tile,
return tile->media_gt;
default:
break;
- };
+ }
fallthrough;
default:
return tile->primary_gt;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] drm/xe/irq: Remove unnecessary semicolon in pick_engine_gt()
2024-04-15 7:07 [PATCH v2] drm/xe/irq: Remove unnecessary semicolon in pick_engine_gt() Jiapeng Chong
@ 2024-04-15 10:13 ` Chauhan, Shekhar
0 siblings, 0 replies; 2+ messages in thread
From: Chauhan, Shekhar @ 2024-04-15 10:13 UTC (permalink / raw)
To: Jiapeng Chong, lucas.demarchi
Cc: ogabbay, thomas.hellstrom, maarten.lankhorst, mripard,
tzimmermann, airlied, daniel, intel-xe, dri-devel, linux-kernel,
Abaci Robot
On 4/15/2024 12:37, Jiapeng Chong wrote:
> No functional modification involved.
>
> ./drivers/gpu/drm/xe/xe_irq.c:279:3-4: Unneeded semicolon.
What i meant in the first review, was the commit description. The commit
subject looks better now, but the issue remains the same: Line numbers
will change after new code is added, so, it's better to just write it as
"Remove unnecessary semicolon in pick_engine_gt()" instead of
"./drivers/gpu/drm/xe/xe_irq.c:279:3-4: Unneeded semicolon."
With that,
Reviewed-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8757
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> Changes in v2:
> -Make the commit message more clearer.
>
> drivers/gpu/drm/xe/xe_irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
> index 996806353171..5b1a2f46a1b2 100644
> --- a/drivers/gpu/drm/xe/xe_irq.c
> +++ b/drivers/gpu/drm/xe/xe_irq.c
> @@ -276,7 +276,7 @@ static struct xe_gt *pick_engine_gt(struct xe_tile *tile,
> return tile->media_gt;
> default:
> break;
> - };
> + }
> fallthrough;
> default:
> return tile->primary_gt;
--
-shekhar
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-15 10:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-15 7:07 [PATCH v2] drm/xe/irq: Remove unnecessary semicolon in pick_engine_gt() Jiapeng Chong
2024-04-15 10:13 ` Chauhan, Shekhar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox