From: "Nuno Sá" <noname.nuno@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Mircea Caprioru <mircea.caprioru@analog.com>,
Peter Rosin <peda@axentia.se>,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] mux: adgs1408: simplify with spi_get_device_match_data()
Date: Fri, 02 May 2025 08:36:01 +0100 [thread overview]
Message-ID: <f069c82cb8b5f53553738545b8e4e15b54819e35.camel@gmail.com> (raw)
In-Reply-To: <20250501173758.135465-2-krzysztof.kozlowski@linaro.org>
On Thu, 2025-05-01 at 19:37 +0200, Krzysztof Kozlowski wrote:
> Use spi_get_device_match_data() helper to simplify a bit the driver.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
> Resending patch from almost a year ago - there was no response to pings
> either.
>
> Is mux subsystem still alive? Shall it be marked as orphaned?
>
>
> drivers/mux/adgs1408.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mux/adgs1408.c b/drivers/mux/adgs1408.c
> index 22ed051eb1a4..5386cfedcb06 100644
> --- a/drivers/mux/adgs1408.c
> +++ b/drivers/mux/adgs1408.c
> @@ -59,9 +59,7 @@ static int adgs1408_probe(struct spi_device *spi)
> s32 idle_state;
> int ret;
>
> - chip_id = (enum adgs1408_chip_id)device_get_match_data(dev);
> - if (!chip_id)
> - chip_id = spi_get_device_id(spi)->driver_data;
> + chip_id = (enum adgs1408_chip_id)spi_get_device_match_data(spi);
>
> mux_chip = devm_mux_chip_alloc(dev, 1, 0);
> if (IS_ERR(mux_chip))
prev parent reply other threads:[~2025-05-02 7:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 17:37 [RESEND PATCH] mux: adgs1408: simplify with spi_get_device_match_data() Krzysztof Kozlowski
2025-05-02 7:36 ` Nuno Sá [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f069c82cb8b5f53553738545b8e4e15b54819e35.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mircea.caprioru@analog.com \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox