* [RESEND PATCH] mux: adgs1408: simplify with spi_get_device_match_data()
@ 2025-05-01 17:37 Krzysztof Kozlowski
2025-05-02 7:36 ` Nuno Sá
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-01 17:37 UTC (permalink / raw)
To: Mircea Caprioru, Peter Rosin, linux-kernel; +Cc: Krzysztof Kozlowski
Use spi_get_device_match_data() helper to simplify a bit the driver.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Resending patch from almost a year ago - there was no response to pings
either.
Is mux subsystem still alive? Shall it be marked as orphaned?
drivers/mux/adgs1408.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mux/adgs1408.c b/drivers/mux/adgs1408.c
index 22ed051eb1a4..5386cfedcb06 100644
--- a/drivers/mux/adgs1408.c
+++ b/drivers/mux/adgs1408.c
@@ -59,9 +59,7 @@ static int adgs1408_probe(struct spi_device *spi)
s32 idle_state;
int ret;
- chip_id = (enum adgs1408_chip_id)device_get_match_data(dev);
- if (!chip_id)
- chip_id = spi_get_device_id(spi)->driver_data;
+ chip_id = (enum adgs1408_chip_id)spi_get_device_match_data(spi);
mux_chip = devm_mux_chip_alloc(dev, 1, 0);
if (IS_ERR(mux_chip))
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH] mux: adgs1408: simplify with spi_get_device_match_data()
2025-05-01 17:37 [RESEND PATCH] mux: adgs1408: simplify with spi_get_device_match_data() Krzysztof Kozlowski
@ 2025-05-02 7:36 ` Nuno Sá
0 siblings, 0 replies; 2+ messages in thread
From: Nuno Sá @ 2025-05-02 7:36 UTC (permalink / raw)
To: Krzysztof Kozlowski, Mircea Caprioru, Peter Rosin, linux-kernel
On Thu, 2025-05-01 at 19:37 +0200, Krzysztof Kozlowski wrote:
> Use spi_get_device_match_data() helper to simplify a bit the driver.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
> Resending patch from almost a year ago - there was no response to pings
> either.
>
> Is mux subsystem still alive? Shall it be marked as orphaned?
>
>
> drivers/mux/adgs1408.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mux/adgs1408.c b/drivers/mux/adgs1408.c
> index 22ed051eb1a4..5386cfedcb06 100644
> --- a/drivers/mux/adgs1408.c
> +++ b/drivers/mux/adgs1408.c
> @@ -59,9 +59,7 @@ static int adgs1408_probe(struct spi_device *spi)
> s32 idle_state;
> int ret;
>
> - chip_id = (enum adgs1408_chip_id)device_get_match_data(dev);
> - if (!chip_id)
> - chip_id = spi_get_device_id(spi)->driver_data;
> + chip_id = (enum adgs1408_chip_id)spi_get_device_match_data(spi);
>
> mux_chip = devm_mux_chip_alloc(dev, 1, 0);
> if (IS_ERR(mux_chip))
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-02 7:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-01 17:37 [RESEND PATCH] mux: adgs1408: simplify with spi_get_device_match_data() Krzysztof Kozlowski
2025-05-02 7:36 ` Nuno Sá
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox