* [PATCH] media: imx-pxp: fix ERR_PTR dereference in pxp_probe()
@ 2024-05-14 9:44 Harshit Mogalapalli
2024-05-14 9:46 ` Harshit Mogalapalli
0 siblings, 1 reply; 2+ messages in thread
From: Harshit Mogalapalli @ 2024-05-14 9:44 UTC (permalink / raw)
To: Philipp Zabel, Mauro Carvalho Chehab, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Michael Tretter,
Laurent Pinchart, linux-media, imx, linux-arm-kernel,
linux-kernel
Cc: dan.carpenter, kernel-janitors, error27, harshit.m.mogalapalli
devm_regmap_init_mmio() can fail, add a check and bail out in case of
error.
Fixes: 4e5bd3fdbeb3 ("media: imx-pxp: convert to regmap")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
---
drivers/media/platform/nxp/imx-pxp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/nxp/imx-pxp.c b/drivers/media/platform/nxp/imx-pxp.c
index e62dc5c1a4ae..58c10156c7a4 100644
--- a/drivers/media/platform/nxp/imx-pxp.c
+++ b/drivers/media/platform/nxp/imx-pxp.c
@@ -1805,6 +1805,9 @@ static int pxp_probe(struct platform_device *pdev)
return PTR_ERR(mmio);
dev->regmap = devm_regmap_init_mmio(&pdev->dev, mmio,
&pxp_regmap_config);
+ if (IS_ERR(dev->regmap))
+ return dev_err_probe(&pdev->dev, PTR_ERR(dev->regmap),
+ "Failed to init regmap: %d\n");
irq = platform_get_irq(pdev, 0);
if (irq < 0)
--
2.39.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: imx-pxp: fix ERR_PTR dereference in pxp_probe()
2024-05-14 9:44 [PATCH] media: imx-pxp: fix ERR_PTR dereference in pxp_probe() Harshit Mogalapalli
@ 2024-05-14 9:46 ` Harshit Mogalapalli
0 siblings, 0 replies; 2+ messages in thread
From: Harshit Mogalapalli @ 2024-05-14 9:46 UTC (permalink / raw)
To: Philipp Zabel, Mauro Carvalho Chehab, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Michael Tretter,
Laurent Pinchart, linux-media, imx, linux-arm-kernel,
linux-kernel
Cc: dan.carpenter, kernel-janitors, error27
Hi,
On 14/05/24 15:14, Harshit Mogalapalli wrote:
> devm_regmap_init_mmio() can fail, add a check and bail out in case of
> error.
>
Please ignore this patch, I will send a V2.(v1->v2, I have to remove %d
in error message)
Thanks,
Harshit
> Fixes: 4e5bd3fdbeb3 ("media: imx-pxp: convert to regmap")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
> drivers/media/platform/nxp/imx-pxp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/platform/nxp/imx-pxp.c b/drivers/media/platform/nxp/imx-pxp.c
> index e62dc5c1a4ae..58c10156c7a4 100644
> --- a/drivers/media/platform/nxp/imx-pxp.c
> +++ b/drivers/media/platform/nxp/imx-pxp.c
> @@ -1805,6 +1805,9 @@ static int pxp_probe(struct platform_device *pdev)
> return PTR_ERR(mmio);
> dev->regmap = devm_regmap_init_mmio(&pdev->dev, mmio,
> &pxp_regmap_config);
> + if (IS_ERR(dev->regmap))
> + return dev_err_probe(&pdev->dev, PTR_ERR(dev->regmap),
> + "Failed to init regmap: %d\n");
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-14 9:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-14 9:44 [PATCH] media: imx-pxp: fix ERR_PTR dereference in pxp_probe() Harshit Mogalapalli
2024-05-14 9:46 ` Harshit Mogalapalli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox