From: Martin KaFai Lau <martin.lau@linux.dev>
To: "Bastien Curutchet (eBPF Foundation)" <bastien.curutchet@bootlin.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Mykola Lysenko <mykolal@fb.com>,
Shuah Khan <shuah@kernel.org>,
Alexis Lothore <alexis.lothore@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v3 12/14] selftests/bpf: test_xdp_veth: Add XDP broadcast redirection tests
Date: Tue, 28 Jan 2025 15:03:01 -0800 [thread overview]
Message-ID: <f0eb6d62-695b-461c-9a45-3926f590e413@linux.dev> (raw)
In-Reply-To: <20250128-redirect-multi-v3-12-c1ce69997c01@bootlin.com>
On 1/28/25 1:57 AM, Bastien Curutchet (eBPF Foundation) wrote:
> Set the tests to run serially to avoid conflicts with
> test_xdp_veth_redirect
I think this has been fixed in v3?
Others lgtm also. Thanks for working on this.
> +void test_xdp_veth_broadcast_redirect(void)
> +{
> + if (test__start_subtest("0/BROADCAST"))
> + xdp_veth_broadcast_redirect(0, BPF_F_BROADCAST);
> +
> + if (test__start_subtest("0/(BROADCAST | EXCLUDE_INGRESS)"))
> + xdp_veth_broadcast_redirect(0, BPF_F_BROADCAST | BPF_F_EXCLUDE_INGRESS);
> +
> + if (test__start_subtest("DRV_MODE/BROADCAST"))
> + xdp_veth_broadcast_redirect(XDP_FLAGS_DRV_MODE, BPF_F_BROADCAST);
> +
> + if (test__start_subtest("DRV_MODE/(BROADCAST | EXCLUDE_INGRESS)"))
> + xdp_veth_broadcast_redirect(XDP_FLAGS_DRV_MODE,
> + BPF_F_BROADCAST | BPF_F_EXCLUDE_INGRESS);
> +
> + if (test__start_subtest("SKB_MODE/BROADCAST"))
> + xdp_veth_broadcast_redirect(XDP_FLAGS_SKB_MODE, BPF_F_BROADCAST);
> +
> + if (test__start_subtest("SKB_MODE/(BROADCAST | EXCLUDE_INGRESS)"))
> + xdp_veth_broadcast_redirect(XDP_FLAGS_SKB_MODE,
> + BPF_F_BROADCAST | BPF_F_EXCLUDE_INGRESS);
> +}
next prev parent reply other threads:[~2025-01-28 23:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 9:57 [PATCH bpf-next v3 00/14] selftests/bpf: Migrate test_xdp_redirect_multi.sh to test_progs Bastien Curutchet (eBPF Foundation)
2025-01-28 9:57 ` [PATCH bpf-next v3 01/14] selftests/bpf: helpers: Add append_tid() Bastien Curutchet (eBPF Foundation)
2025-01-28 22:49 ` Martin KaFai Lau
2025-01-29 6:57 ` Bastien Curutchet
2025-01-28 9:57 ` [PATCH bpf-next v3 02/14] selftests/bpf: test_xdp_veth: Remove unused defines Bastien Curutchet (eBPF Foundation)
2025-01-28 9:57 ` [PATCH bpf-next v3 03/14] selftests/bpf: test_xdp_veth: Remove unecessarry check_ping() Bastien Curutchet (eBPF Foundation)
2025-01-28 9:57 ` [PATCH bpf-next v3 04/14] selftests/bpf: test_xdp_veth: Use int to describe next veth Bastien Curutchet (eBPF Foundation)
2025-01-28 9:57 ` [PATCH bpf-next v3 05/14] selftests/bpf: test_xdp_veth: Split network configuration Bastien Curutchet (eBPF Foundation)
2025-01-28 9:57 ` [PATCH bpf-next v3 06/14] selftests/bpf: test_xdp_veth: Rename config[] Bastien Curutchet (eBPF Foundation)
2025-01-28 9:57 ` [PATCH bpf-next v3 07/14] selftests/bpf: test_xdp_veth: Add prog_config[] table Bastien Curutchet (eBPF Foundation)
2025-01-28 9:57 ` [PATCH bpf-next v3 08/14] selftests/bpf: test_xdp_veth: Add XDP flags to prog_configuration Bastien Curutchet (eBPF Foundation)
2025-01-28 9:57 ` [PATCH bpf-next v3 09/14] selftests/bpf: test_xdp_veth: Use unique names Bastien Curutchet (eBPF Foundation)
2025-01-28 23:00 ` Martin KaFai Lau
2025-01-28 9:57 ` [PATCH bpf-next v3 10/14] selftests/bpf: test_xdp_veth: Add new test cases for XDP flags Bastien Curutchet (eBPF Foundation)
2025-01-28 9:57 ` [PATCH bpf-next v3 11/14] selftests/bpf: Optionally select broadcasting flags Bastien Curutchet (eBPF Foundation)
2025-01-28 9:57 ` [PATCH bpf-next v3 12/14] selftests/bpf: test_xdp_veth: Add XDP broadcast redirection tests Bastien Curutchet (eBPF Foundation)
2025-01-28 23:03 ` Martin KaFai Lau [this message]
2025-01-29 7:08 ` Bastien Curutchet
2025-01-28 9:57 ` [PATCH bpf-next v3 13/14] selftests/bpf: test_xdp_veth: Add XDP program on egress test Bastien Curutchet (eBPF Foundation)
2025-01-28 9:57 ` [PATCH bpf-next v3 14/14] selftests/bpf: Remove test_xdp_redirect_multi.sh Bastien Curutchet (eBPF Foundation)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0eb6d62-695b-461c-9a45-3926f590e413@linux.dev \
--to=martin.lau@linux.dev \
--cc=alexis.lothore@bootlin.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bastien.curutchet@bootlin.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox