* [PATCH] Date: Remove unused macro
@ 2024-09-05 8:52 zhangjiao2
2024-09-05 16:08 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: zhangjiao2 @ 2024-09-05 8:52 UTC (permalink / raw)
To: shuah
Cc: jstultz, tglx, anna-maria, frederic, linux-kernel,
linux-kselftest, zhang jiao
From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
This macro NSEC_PER_SEC is never referenced in the code.
Just remove it.
Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
---
tools/testing/selftests/timers/change_skew.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/testing/selftests/timers/change_skew.c b/tools/testing/selftests/timers/change_skew.c
index 4421cd562c24..18e794a46c23 100644
--- a/tools/testing/selftests/timers/change_skew.c
+++ b/tools/testing/selftests/timers/change_skew.c
@@ -30,9 +30,6 @@
#include <time.h>
#include "../kselftest.h"
-#define NSEC_PER_SEC 1000000000LL
-
-
int change_skew_test(int ppm)
{
struct timex tx;
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Date: Remove unused macro
2024-09-05 8:52 [PATCH] Date: Remove unused macro zhangjiao2
@ 2024-09-05 16:08 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2024-09-05 16:08 UTC (permalink / raw)
To: zhangjiao2, shuah
Cc: jstultz, tglx, anna-maria, frederic, linux-kernel,
linux-kselftest, Shuah Khan
On 9/5/24 02:52, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
>
> This macro NSEC_PER_SEC is never referenced in the code.
> Just remove it.
Is this duplicate patch?
I think I commented on your patch on futex - include how
you found the problem in change logs. Also you have to
include subsystem prefix in the subject line:
selftests/timers: Remove unused NSEC_PER_SEC macro
I see another patch with similar problems from you.
Refer to submitting patches document in the kernel
repo.
>
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> ---
> tools/testing/selftests/timers/change_skew.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/testing/selftests/timers/change_skew.c b/tools/testing/selftests/timers/change_skew.c
> index 4421cd562c24..18e794a46c23 100644
> --- a/tools/testing/selftests/timers/change_skew.c
> +++ b/tools/testing/selftests/timers/change_skew.c
> @@ -30,9 +30,6 @@
> #include <time.h>
> #include "../kselftest.h"
>
> -#define NSEC_PER_SEC 1000000000LL
> -
> -
> int change_skew_test(int ppm)
> {
> struct timex tx;
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Date: Remove unused macro
@ 2024-09-05 8:13 zhangjiao2
2024-09-05 16:07 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: zhangjiao2 @ 2024-09-05 8:13 UTC (permalink / raw)
To: anna-maria
Cc: frederic, tglx, jstultz, shuah, linux-kernel, linux-kselftest,
zhang jiao
From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
This macro NSEC_PER_SEC is never referenced in the code.
Just remove it.
Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
---
tools/testing/selftests/timers/skew_consistency.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/testing/selftests/timers/skew_consistency.c b/tools/testing/selftests/timers/skew_consistency.c
index c8e6bffe4e0a..83450145fe65 100644
--- a/tools/testing/selftests/timers/skew_consistency.c
+++ b/tools/testing/selftests/timers/skew_consistency.c
@@ -36,8 +36,6 @@
#include <sys/wait.h>
#include "../kselftest.h"
-#define NSEC_PER_SEC 1000000000LL
-
int main(int argc, char **argv)
{
struct timex tx;
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Date: Remove unused macro
2024-09-05 8:13 zhangjiao2
@ 2024-09-05 16:07 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2024-09-05 16:07 UTC (permalink / raw)
To: zhangjiao2, anna-maria
Cc: frederic, tglx, jstultz, shuah, linux-kernel, linux-kselftest,
Shuah Khan
On 9/5/24 02:13, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
>
> This macro NSEC_PER_SEC is never referenced in the code.
> Just remove it.
I think I commented on your patch on futex - include how
you found the problem in change logs. Also you have to
include subsystem prefix in the subject line:
selftests/timers: Remove unused NSEC_PER_SEC macro
I see another patch with similar problems from you.
Refer to submitting patches document in the kernel
repo.
>
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> ---
> tools/testing/selftests/timers/skew_consistency.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/selftests/timers/skew_consistency.c b/tools/testing/selftests/timers/skew_consistency.c
> index c8e6bffe4e0a..83450145fe65 100644
> --- a/tools/testing/selftests/timers/skew_consistency.c
> +++ b/tools/testing/selftests/timers/skew_consistency.c
> @@ -36,8 +36,6 @@
> #include <sys/wait.h>
> #include "../kselftest.h"
>
> -#define NSEC_PER_SEC 1000000000LL
> -
> int main(int argc, char **argv)
> {
> struct timex tx;
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-09-05 16:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-05 8:52 [PATCH] Date: Remove unused macro zhangjiao2
2024-09-05 16:08 ` Shuah Khan
-- strict thread matches above, loose matches on Subject: below --
2024-09-05 8:13 zhangjiao2
2024-09-05 16:07 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox