From: Ping-Ke Shih <pkshih@realtek.com>
To: Shiji Yang <yangshiji66@outlook.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Jes Sorensen <Jes.Sorensen@gmail.com>,
Kalle Valo <kvalo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] wifi: rtl8xxxu: fix mixed declarations in rtl8xxxu_set_aifs()
Date: Mon, 26 Feb 2024 01:18:05 +0000 [thread overview]
Message-ID: <f281e9b6073143e7912f5d9ddb6ee217@realtek.com> (raw)
In-Reply-To: <TYAP286MB03157A408E0D69F2F6FBD88ABC552@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM>
> -----Original Message-----
> From: Shiji Yang <yangshiji66@outlook.com>
> Sent: Friday, February 23, 2024 9:35 PM
> To: linux-wireless@vger.kernel.org
> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>; Kalle Valo <kvalo@kernel.org>; linux-kernel@vger.kernel.org;
> Shiji Yang <yangshiji66@outlook.com>
> Subject: [PATCH] wifi: rtl8xxxu: fix mixed declarations in rtl8xxxu_set_aifs()
>
> Moving struct ieee80211_sta *sta variable definition to the front
> of the code to fix the ISO C90 forbids mixed declarations and code
> warning.
I suppose there will be no this kind of warnings after
the commit b5ec6fd286df ("kbuild: Drop -Wdeclaration-after-statement") since
v6.5. But as commit message mentioned --
" It will still be recommeneded to place declarations at the start of a
scope where possible, but it will no longer be enforced."
Then, this patch looks good to me.
>
> Fixes: 43532c050f8e ("wifi: rtl8xxxu: support multiple interfaces in set_aifs()")
> Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
next prev parent reply other threads:[~2024-02-26 1:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 13:34 [PATCH] wifi: rtl8xxxu: fix mixed declarations in rtl8xxxu_set_aifs() Shiji Yang
2024-02-26 1:18 ` Ping-Ke Shih [this message]
2024-02-28 11:38 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f281e9b6073143e7912f5d9ddb6ee217@realtek.com \
--to=pkshih@realtek.com \
--cc=Jes.Sorensen@gmail.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yangshiji66@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox