public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hao Yao <hao.yao@intel.com>
To: <johannes.goede@oss.qualcomm.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Bingbu Cao <bingbu.cao@linux.intel.com>
Cc: <platform-driver-x86@vger.kernel.org>, <hdegoede@redhat.com>,
	<dan.scally@ideasonboard.com>, <ilpo.jarvinen@linux.intel.com>,
	<bingbu.cao@intel.com>, <linux-media@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: int3472: Use actual clock frequency for DSM method
Date: Mon, 8 Dec 2025 11:55:19 +0800	[thread overview]
Message-ID: <f30d1971-71f3-4c72-9a68-b8203b8fc194@intel.com> (raw)
In-Reply-To: <d036f6dc-1150-4478-a3a2-cdb5723ae4c7@oss.qualcomm.com>

Hi Hans,

On 12/7/25 22:43, johannes.goede@oss.qualcomm.com wrote:
> Hi,
> 
> On 5-Dec-25 8:05 PM, Sakari Ailus wrote:
>> On Fri, Dec 05, 2025 at 06:10:10PM +0800, Bingbu Cao wrote:
>>>> +#define PCH_CLK_FREQ_19M	1
>>>
>>> I like 19P2MHZ.
>>
>> How about simply PCH_CLK_FREQ_19M2?
> 
> +1 for this, this is the standard way to write fractional
> MHz clocks.

Thank you. Will fix here in v2 patch.


Best Regards,
Hao Yao

> 
> With that fixed / so for v2:
> 
> Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
> 
> Regards,
> 
> Hans
> 
> 


  reply	other threads:[~2025-12-08  3:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-05  9:51 [PATCH] platform/x86: int3472: Use actual clock frequency for DSM method Hao Yao
2025-12-05 10:10 ` Bingbu Cao
2025-12-05 19:05   ` Sakari Ailus
2025-12-07 14:43     ` johannes.goede
2025-12-08  3:55       ` Hao Yao [this message]
2025-12-08  3:53   ` Hao Yao
2025-12-08 16:22     ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f30d1971-71f3-4c72-9a68-b8203b8fc194@intel.com \
    --to=hao.yao@intel.com \
    --cc=bingbu.cao@intel.com \
    --cc=bingbu.cao@linux.intel.com \
    --cc=dan.scally@ideasonboard.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=johannes.goede@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox