From: Shuah Khan <skhan@linuxfoundation.org>
To: "Yohei Kojima" <yk@y-koj.net>,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: Shuah Khan <shuah@kernel.org>,
Brendan Jackman <jackmanb@google.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] selftests: runner: Avoid spurious warning about missing failures file
Date: Mon, 27 Apr 2026 10:20:43 -0600 [thread overview]
Message-ID: <f4a213da-7016-4d87-a93f-ea205ab05aae@linuxfoundation.org> (raw)
In-Reply-To: <4915db6e-5bcf-4f70-b510-693f5d5b8678@linuxfoundation.org>
On 4/22/26 08:51, Shuah Khan wrote:
> On 4/9/26 07:38, Yohei Kojima wrote:
>> On Tue, Feb 24, 2026 at 04:37:56PM +0100, Thomas Weißschuh wrote:
>>> When runner.sh is *not* executed via run_kselftest.sh, the variable
>>> $kselftest_failures_file does not exist. This triggers a harmless but
>>> annyoing warning from runner.sh if a test fails:
>>>
>>> tools/testing/selftests/kselftest/runner.sh: line 50: : No such file or directory
>>>
>>> Silence the spurious warning.
>>>
>>> Fixes: d9e6269e3303 ("selftests/run_kselftest.sh: exit with error if tests fail")
>>> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
>>> Reviewed-By: Brendan Jackman <jackmanb@google.com>
>>
>> Hi all,
>>
>> It seems this patch hasn't been picked up yet, although it already got
>> reviewed by Brendan. This bug is also mentioned by a netdev maintainer
>> and several developers [1], so I think it would be nice to have this
>> patch merged.
>>
>> [1]: https://lore.kernel.org/lkml/20260112135326.7ce71119@kernel.org/
>>
>> I confirmed that it still applies to 7.0-rc7. I also tested it by adding
>> a failing test to net and namespaces selftests, and confirmed that the
>> error disappeared.
>>
>> Tested-by: Yohei Kojima <yk@y-koj.net>
>>
>
> Sorry for the delay.
>
> It disappeared in my Inbox - I will pick this up for Linux 7.1-rc2
>
Thomas,
Please rebase on Linux 7.1-rc1 and send it to me?
thanks,
-- Shuah
next prev parent reply other threads:[~2026-04-27 16:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 15:37 [PATCH v2] selftests: runner: Avoid spurious warning about missing failures file Thomas Weißschuh
2026-04-09 13:38 ` Yohei Kojima
2026-04-22 14:51 ` Shuah Khan
2026-04-27 16:20 ` Shuah Khan [this message]
2026-04-29 11:12 ` Thomas Weißschuh
2026-04-30 21:21 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4a213da-7016-4d87-a93f-ea205ab05aae@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=jackmanb@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=thomas.weissschuh@linutronix.de \
--cc=yk@y-koj.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox