Re: [PATCH v2] selftests: runner: Avoid spurious warning about missing failures file

[Shuah Khan <skhan@linuxfoundation.org>]

On 4/29/26 05:12, Thomas Weißschuh wrote:
> On Mon, Apr 27, 2026 at 10:20:43AM -0600, Shuah Khan wrote:
>> On 4/22/26 08:51, Shuah Khan wrote:
>>> On 4/9/26 07:38, Yohei Kojima wrote:
>>>> On Tue, Feb 24, 2026 at 04:37:56PM +0100, Thomas Weißschuh wrote:
>>>>> When runner.sh is *not* executed via run_kselftest.sh, the variable
>>>>> $kselftest_failures_file does not exist. This triggers a harmless but
>>>>> annyoing warning from runner.sh if a test fails:
>>>>>
>>>>> tools/testing/selftests/kselftest/runner.sh: line 50: : No such file or directory
>>>>>
>>>>> Silence the spurious warning.
>>>>>
>>>>> Fixes: d9e6269e3303 ("selftests/run_kselftest.sh: exit with error if tests fail")
>>>>> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
>>>>> Reviewed-By: Brendan Jackman <jackmanb@google.com>
>>>>
>>>> Hi all,
>>>>
>>>> It seems this patch hasn't been picked up yet, although it already got
>>>> reviewed by Brendan. This bug is also mentioned by a netdev maintainer
>>>> and several developers [1], so I think it would be nice to have this
>>>> patch merged.
>>>>
>>>> [1]: https://lore.kernel.org/lkml/20260112135326.7ce71119@kernel.org/
>>>>
>>>> I confirmed that it still applies to 7.0-rc7. I also tested it by adding
>>>> a failing test to net and namespaces selftests, and confirmed that the
>>>> error disappeared.
>>>>
>>>> Tested-by: Yohei Kojima <yk@y-koj.net>
>>>>
>>>
>>> Sorry for the delay.
>>>
>>> It disappeared in my Inbox - I will pick this up for Linux 7.1-rc2
>>
>> Please rebase on Linux 7.1-rc1 and send it to me?
> 
> This actually doesn't seem to be necessary anymore since commit 2964f6b816c2
> ("selftests: Use ktap helpers for runner.sh"). So let's drop it.
> 
> 


Thanks for confirming.

-- Shuah