From: David Ahern <dsahern@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: menglong8.dong@gmail.com, pabeni@redhat.com, rostedt@goodmis.org,
mingo@redhat.com, xeb@mail.ru, davem@davemloft.net,
yoshfuji@linux-ipv6.org, imagedong@tencent.com,
edumazet@google.com, kafai@fb.com, talalahmad@google.com,
keescook@chromium.org, alobakin@pm.me, flyingpeng@tencent.com,
mengensun@tencent.com, dongli.zhang@oracle.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
benbjiang@tencent.com
Subject: Re: [PATCH net-next v3 3/3] net: icmp: add reasons of the skb drops to icmp protocol
Date: Thu, 17 Mar 2022 08:48:44 -0600 [thread overview]
Message-ID: <f787c35b-0984-ecaf-ad97-c7580fcdbbad@kernel.org> (raw)
In-Reply-To: <20220316210534.06b6cfe0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 3/16/22 10:05 PM, Jakub Kicinski wrote:
> On Wed, 16 Mar 2022 21:35:47 -0600 David Ahern wrote:
>> On 3/16/22 9:18 PM, Jakub Kicinski wrote:
>>>
>>> I guess this set raises the follow up question to Dave if adding
>>> drop reasons to places with MIB exception stats means improving
>>> the granularity or one MIB stat == one reason?
>>
>> There are a few examples where multiple MIB stats are bumped on a drop,
>> but the reason code should always be set based on first failure. Did you
>> mean something else with your question?
>
> I meant whether we want to differentiate between TYPE, and BROADCAST or
> whatever other possible invalid protocol cases we can get here or just
> dump them all into a single protocol error code.
I think a single one is a good starting point.
next prev parent reply other threads:[~2022-03-17 14:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 6:31 [PATCH net-next v3 0/3] net: icmp: add skb drop reasons to icmp menglong8.dong
2022-03-16 6:31 ` [PATCH net-next v3 1/3] net: sock: introduce sock_queue_rcv_skb_reason() menglong8.dong
2022-03-16 6:31 ` [PATCH net-next v3 2/3] net: icmp: introduce __ping_queue_rcv_skb() to report drop reasons menglong8.dong
2022-03-17 3:56 ` David Ahern
2022-03-17 5:25 ` Menglong Dong
2022-03-17 8:33 ` Paolo Abeni
2022-03-17 8:36 ` Menglong Dong
2022-03-16 6:31 ` [PATCH net-next v3 3/3] net: icmp: add reasons of the skb drops to icmp protocol menglong8.dong
2022-03-17 3:18 ` Jakub Kicinski
2022-03-17 3:35 ` David Ahern
2022-03-17 4:05 ` Jakub Kicinski
2022-03-17 6:02 ` Menglong Dong
2022-03-17 14:48 ` David Ahern [this message]
2022-03-17 14:53 ` David Laight
2022-03-17 15:49 ` David Ahern
2022-03-18 1:37 ` Menglong Dong
2022-03-18 4:10 ` David Ahern
2022-03-18 7:26 ` Menglong Dong
2022-03-18 22:33 ` David Ahern
2022-03-20 13:27 ` Menglong Dong
2022-03-17 5:57 ` Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f787c35b-0984-ecaf-ad97-c7580fcdbbad@kernel.org \
--to=dsahern@kernel.org \
--cc=alobakin@pm.me \
--cc=benbjiang@tencent.com \
--cc=davem@davemloft.net \
--cc=dongli.zhang@oracle.com \
--cc=edumazet@google.com \
--cc=flyingpeng@tencent.com \
--cc=imagedong@tencent.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mengensun@tencent.com \
--cc=menglong8.dong@gmail.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
--cc=talalahmad@google.com \
--cc=xeb@mail.ru \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox