From: Tom Lendacky <thomas.lendacky@amd.com>
To: Borislav Petkov <bp@alien8.de>, Pavan Kumar Paluri <papaluri@amd.com>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-coco@lists.linux.dev, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Eric Van Tassell <Eric.VanTassell@amd.com>,
Ashish Kalra <ashish.kalra@amd.com>,
Michael Roth <michael.roth@amd.com>,
"H . Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Dhaval Giani <dhaval.giani@amd.com>
Subject: Re: [PATCH v6 1/2] x86, KVM:SVM: Move sev specific parsing into arch/x86/virt/svm
Date: Fri, 11 Oct 2024 11:35:40 -0500 [thread overview]
Message-ID: <f8a3a683-0cdd-d1bb-1904-521ce5a96dac@amd.com> (raw)
In-Reply-To: <20241011162120.GDZwlQgKTFi22JZ5If@fat_crate.local>
On 10/11/24 11:21, Borislav Petkov wrote:
> On Thu, Oct 10, 2024 at 07:14:54AM -0500, Pavan Kumar Paluri wrote:
>> Move SEV specific kernel command line option parsing support from
>> arch/x86/coco/sev/core.c to arch/x86/virt/svm/cmdline.c so that both
>> host and guest related SEV command line options can be supported.
>>
>> No functional changes intended.
>>
>> Signed-off-by: Pavan Kumar Paluri <papaluri@amd.com>
>> Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
>> ---
>> arch/x86/coco/sev/core.c | 44 -------------------------------
>> arch/x86/include/asm/sev-common.h | 27 +++++++++++++++++++
>> arch/x86/virt/svm/Makefile | 1 +
>> arch/x86/virt/svm/cmdline.c | 32 ++++++++++++++++++++++
>> 4 files changed, 60 insertions(+), 44 deletions(-)
>> create mode 100644 arch/x86/virt/svm/cmdline.c
>
> make[5]: *** No rule to make target 'arch/x86/virt/svm/cmdline.o', needed by 'arch/x86/virt/svm/built-in.a'. Stop.
> make[5]: *** Waiting for unfinished jobs....
> make[4]: *** [scripts/Makefile.build:478: arch/x86/virt/svm] Error 2
> make[3]: *** [scripts/Makefile.build:478: arch/x86/virt] Error 2
> make[3]: *** Waiting for unfinished jobs....
> make[2]: *** [scripts/Makefile.build:478: arch/x86] Error 2
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/mnt/kernel/kernel/linux/Makefile:1936: .] Error 2
> make: *** [Makefile:224: __sub-make] Error 2
>
> $ ls arch/x86/virt/svm/cmdline.c
> ls: cannot access 'arch/x86/virt/svm/cmdline.c': No such file or directory
>
> Looks like you forgot to git add cmdline.c before committing.
But the patch includes the new file, so how can that be?
Thanks,
Tom
>
next prev parent reply other threads:[~2024-10-11 16:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 12:14 [PATCH v6 0/2] nosnp sev command line support Pavan Kumar Paluri
2024-10-10 12:14 ` [PATCH v6 1/2] x86, KVM:SVM: Move sev specific parsing into arch/x86/virt/svm Pavan Kumar Paluri
2024-10-11 16:21 ` Borislav Petkov
2024-10-11 16:35 ` Tom Lendacky [this message]
2024-10-11 16:48 ` Borislav Petkov
2024-10-11 16:55 ` Tom Lendacky
2024-10-11 16:59 ` Borislav Petkov
2024-10-11 17:08 ` Paluri, PavanKumar
2024-10-11 22:16 ` Borislav Petkov
2024-10-10 12:14 ` [PATCH v6 2/2] x86 KVM:SVM: Provide "nosnp" boot option for sev kernel command line Pavan Kumar Paluri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8a3a683-0cdd-d1bb-1904-521ce5a96dac@amd.com \
--to=thomas.lendacky@amd.com \
--cc=Eric.VanTassell@amd.com \
--cc=ashish.kalra@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dhaval.giani@amd.com \
--cc=hpa@zytor.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=papaluri@amd.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox