From: "Paluri, PavanKumar" <papaluri@amd.com>
To: Borislav Petkov <bp@alien8.de>, Tom Lendacky <thomas.lendacky@amd.com>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-coco@lists.linux.dev, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Eric Van Tassell <Eric.VanTassell@amd.com>,
Ashish Kalra <ashish.kalra@amd.com>,
Michael Roth <michael.roth@amd.com>,
"H . Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Dhaval Giani <dhaval.giani@amd.com>
Subject: Re: [PATCH v6 1/2] x86, KVM:SVM: Move sev specific parsing into arch/x86/virt/svm
Date: Fri, 11 Oct 2024 12:08:34 -0500 [thread overview]
Message-ID: <07b4dd67-9e09-eb0c-86d2-92fa68938129@amd.com> (raw)
In-Reply-To: <20241011165912.GAZwlZYDO_kz3HQ_ie@fat_crate.local>
Hello Boris,
On 10/11/2024 11:59 AM, Borislav Petkov wrote:
> On Fri, Oct 11, 2024 at 11:55:14AM -0500, Tom Lendacky wrote:
>> Ah, that makes more sense. Looks like he's missing the include for
>> linux/cache.h
>
> "Changelog:
> =========
> v5:
> ...
> * Remove <asm/cache.h> stray header introduced in the previous
> versions because of __read_mostly attribute that is now moved into
> virt/svm/cmdline.c"
>
Yes, I am very sorry. I should have done a progressive build, which
could have helped me in spotting this issue.
This changelog points at removing <asm/cache.h> from
arch/x86/include/asm/sev-common.h (where __read_mostly was previously
present) and forgot to include this header to where it is now relocated
to. I will address this. On building the patchset (1 and 2 together), I
do not see the error, so this should have occurred on just building
Patch #1.
Thanks for the review.
Pavan
next prev parent reply other threads:[~2024-10-11 17:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 12:14 [PATCH v6 0/2] nosnp sev command line support Pavan Kumar Paluri
2024-10-10 12:14 ` [PATCH v6 1/2] x86, KVM:SVM: Move sev specific parsing into arch/x86/virt/svm Pavan Kumar Paluri
2024-10-11 16:21 ` Borislav Petkov
2024-10-11 16:35 ` Tom Lendacky
2024-10-11 16:48 ` Borislav Petkov
2024-10-11 16:55 ` Tom Lendacky
2024-10-11 16:59 ` Borislav Petkov
2024-10-11 17:08 ` Paluri, PavanKumar [this message]
2024-10-11 22:16 ` Borislav Petkov
2024-10-10 12:14 ` [PATCH v6 2/2] x86 KVM:SVM: Provide "nosnp" boot option for sev kernel command line Pavan Kumar Paluri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07b4dd67-9e09-eb0c-86d2-92fa68938129@amd.com \
--to=papaluri@amd.com \
--cc=Eric.VanTassell@amd.com \
--cc=ashish.kalra@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dhaval.giani@amd.com \
--cc=hpa@zytor.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox