Re: [PATCH v2 3/3] drm/panel: ilitek-ili9805: make cleanup funcs void

[neil.armstrong@linaro.org]

On 7/19/26 21:03, Michail Tatas wrote:
> Make cleanup functions return void since no one is checking
> their return values
> 
> Signed-off-by: Michail Tatas <michail.tatas@gmail.com>
> ---
>   drivers/gpu/drm/panel/panel-ilitek-ili9805.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c b/drivers/gpu/drm/panel/panel-ilitek-ili9805.c
> index a70b9512746a..64cfaf981e9f 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9805.c
> @@ -148,13 +148,11 @@ static int ili9805_power_on(struct ili9805 *ctx)
>   	return 0;
>   }
>   
> -static int ili9805_power_off(struct ili9805 *ctx)
> +static void ili9805_power_off(struct ili9805 *ctx)
>   {
>   	gpiod_set_value(ctx->reset_gpio, 0);
>   	regulator_disable(ctx->dvdd);
>   	regulator_disable(ctx->avdd);
> -
> -	return 0;
>   }
>   
>   static int ili9805_activate(struct ili9805 *ctx)
> @@ -188,15 +186,13 @@ static int ili9805_prepare(struct drm_panel *panel)
>   	return 0;
>   }
>   
> -static int ili9805_deactivate(struct ili9805 *ctx)
> +static void ili9805_deactivate(struct ili9805 *ctx)
>   {
>   	struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi };
>   
>   	mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
>   	mipi_dsi_usleep_range(&dsi_ctx, 5000, 10000);
>   	mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
> -
> -	return dsi_ctx.accum_err;
>   }
>   
>   static int ili9805_unprepare(struct drm_panel *panel)

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil