From: Guenter Roeck <linux@roeck-us.net>
To: victor.duicu@microchip.com
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
corbet@lwn.net, marius.cristea@microchip.com,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 2/2] hwmon: add support for MCP998X
Date: Tue, 3 Feb 2026 12:09:05 -0800 [thread overview]
Message-ID: <fb5fcb40-1cce-4de8-83a9-c8a7f308505f@roeck-us.net> (raw)
In-Reply-To: <20260127151823.9728-3-victor.duicu@microchip.com>
On Tue, Jan 27, 2026 at 05:18:22PM +0200, victor.duicu@microchip.com wrote:
> From: Victor Duicu <victor.duicu@microchip.com>
>
> This is the driver for Microchip MCP998X/33 and MCP998XD/33D
> Multichannel Automotive Temperature Monitor Family.
>
> Signed-off-by: Victor Duicu <victor.duicu@microchip.com>
> ---
More feedback, with compliments from Gemini :-).
[ ... ]
> + case hwmon_temp:
> + switch (attr) {
> + case hwmon_temp_max:
> + if (channel)
> + addr = MCP9982_EXT_HIGH_LIMIT_ADDR(channel);
> + else
> + addr = MCP9982_INTERNAL_HIGH_LIMIT_ADDR;
> +
> + return ret = mcp9982_write_limit(priv, addr, val);
Pointless assignment to ret.
Thanks,
Guenter
next prev parent reply other threads:[~2026-02-03 20:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 15:18 [PATCH v3 0/2] add support in hwmon for MCP998X victor.duicu
2026-01-27 15:18 ` [PATCH v3 1/2] dt-bindings: hwmon: add support " victor.duicu
2026-02-03 19:15 ` Guenter Roeck
2026-02-06 14:17 ` Victor.Duicu
2026-02-06 16:49 ` Krzysztof Kozlowski
2026-02-06 16:51 ` Krzysztof Kozlowski
2026-02-06 16:47 ` Krzysztof Kozlowski
2026-02-09 14:46 ` Victor.Duicu
2026-01-27 15:18 ` [PATCH v3 2/2] " victor.duicu
2026-01-27 18:51 ` Guenter Roeck
2026-02-02 8:15 ` Victor.Duicu
2026-02-02 15:18 ` Guenter Roeck
2026-02-03 13:31 ` Victor.Duicu
2026-01-27 22:23 ` kernel test robot
2026-02-03 19:45 ` Guenter Roeck
2026-02-03 20:09 ` Guenter Roeck [this message]
2026-02-03 20:45 ` Guenter Roeck
2026-02-06 16:55 ` [PATCH v3 0/2] add support in hwmon " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb5fcb40-1cce-4de8-83a9-c8a7f308505f@roeck-us.net \
--to=linux@roeck-us.net \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marius.cristea@microchip.com \
--cc=robh@kernel.org \
--cc=victor.duicu@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox