From: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Rob Herring <robh@kernel.org>,
Vikram Sharma <quic_vikramsa@quicinc.com>
Cc: <vladimir.zapolskiy@linaro.org>, <bryan.odonoghue@linaro.org>,
<mchehab@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<andersson@kernel.org>, <konradybcio@kernel.org>,
<hverkuil-cisco@xs4all.nl>, <cros-qcom-dts-watchers@chromium.org>,
<catalin.marinas@arm.com>, <will@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<quic_svankada@quicinc.com>, <linux-media@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Ravi Shankar <quic_rshankar@quicinc.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: i2c: qcom-cci: Document qcs8300 compatible
Date: Wed, 17 Sep 2025 11:52:41 +0530 [thread overview]
Message-ID: <fd075b5f-3766-474a-bffe-c1c402cfca81@quicinc.com> (raw)
In-Reply-To: <49d6c554-e6ed-4c86-8946-be2cdba659d0@oss.qualcomm.com>
On 16-09-2025 16:41, Konrad Dybcio wrote:
>>> Wrap commit messages at 72 chars. And explain how it's the same or
>>> different from existing SoCs in the commit message. Don't explain the
>>> diff. We can read that ourselves.
>>>
>> SA8775P(Lemans) has 4 CCIs, while QCS8300 (Monaco) has 3 CCI, with the
>> only difference being the GPIOs used for SDA/SCL pins.
>>
>> Currently, the CCI driver probe happens through the "qcom,msm8996-cci"
>> compatible string. Could we use the existing SA8775P compatible string
>> "qcom,sa8775p-cci" or we should remove it?
>>
>> Please advise on the preferred approach for upstream compliance.
> Try:
>
> """
> The three instances of CCI found on the QCS8300 are functionally
> the same as on a number of existing Qualcomm SoCs.
>
> Introduce a new SoC-specific compatible, with a common fallback.
> """
>
ACK, Will address this in next version.
> Konrad
next prev parent reply other threads:[~2025-09-17 6:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 14:11 [PATCH v2 0/3] Add CCI and imx577 sensor support for monaco evk Vikram Sharma
2025-09-12 14:11 ` [PATCH v2 1/3] dt-bindings: i2c: qcom-cci: Document qcs8300 compatible Vikram Sharma
2025-09-16 2:48 ` Rob Herring
2025-09-16 11:07 ` Nihal Kumar Gupta
2025-09-16 11:11 ` Konrad Dybcio
2025-09-17 6:22 ` Nihal Kumar Gupta [this message]
2025-09-12 14:11 ` [PATCH v2 2/3] arm64: dts: qcom: qcs8300: Add CCI definitions Vikram Sharma
2025-09-12 14:11 ` [PATCH v2 3/3] arm64: dts: qcom: monaco-evk-camera: Add DT overlay Vikram Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd075b5f-3766-474a-bffe-c1c402cfca81@quicinc.com \
--to=quic_nihalkum@quicinc.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_rshankar@quicinc.com \
--cc=quic_svankada@quicinc.com \
--cc=quic_vikramsa@quicinc.com \
--cc=robh@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox