The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abelvesa@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shengchao.guo@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: defconfig: enable the SerDes PHY for Qualcomm SA8255p
Date: Wed, 18 Nov 2026 14:15:59 +0100	[thread overview]
Message-ID: <fdfd177d-b7b5-4583-9dee-b7c593c4a059@kernel.org> (raw)
In-Reply-To: <zcqjdhqvdieq7kwbhfbw6s74q35xedzuzcsffsugqgz7yzfs7q@dynjfs6njtix>

On 18/11/2026 13:51, Bartosz Golaszewski wrote:
> On Wed, Nov 18, 2026 at 01:42:57PM +0100, Krzysztof Kozlowski wrote:
>> On 18/11/2026 11:31, Bartosz Golaszewski wrote:
>>> Enable the SGMII/SerDes PHY driver for the firmware-managed variant of
>>> the Lemans platform. This module is required for ethernet to work on
>>
>> Which Lemans? This is a generic defconfig, not vendor specific.
>>
> 
> SA8255p as per the subject line. In order to not repeat myself, I called
> it "firmware-managed variant of Lemans". I feel like this is
> nit-picking. It's pretty clear on which platform requires that driver.

No, it's not clear. Only you and Qualcomm knows what is Lemans. No one
else knows.

I repeated this feedback already 5 times this month and then every other
month as well.

> 
>>> sa8255p-ride.
>>>
>>
>> `git grep` gives me only piece of a compatible, not even DTS. There is
>> no such board simply. We don't take changes for non-upstream boards.
>>
> 
> What do you mean? The full compatible is "qcom,sa8255p-ride", I dropped
> the vendor prefix as this is a commit message and I mentioned it's
> Qualcomm in the previous paragraph.
> 
> The .dts is now in next as:
>   arch/arm64/boot/dts/qcom/lemans-sa8255p-ride.dts

OK, I looked at next from 13th Nov, so indeed a bit stalled.

Best regards,
Krzysztof

      reply	other threads:[~2026-11-18 13:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 10:31 [PATCH] arm64: defconfig: enable the SerDes PHY for Qualcomm SA8255p Bartosz Golaszewski
2026-11-18 12:42 ` Krzysztof Kozlowski
2026-11-18 12:51   ` Bartosz Golaszewski
2026-11-18 13:15     ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fdfd177d-b7b5-4583-9dee-b7c593c4a059@kernel.org \
    --to=krzk@kernel.org \
    --cc=abelvesa@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=shengchao.guo@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox