The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] arm64: defconfig: enable the SerDes PHY for Qualcomm SA8255p
@ 2026-11-18 10:31 Bartosz Golaszewski
  2026-11-18 12:42 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 4+ messages in thread
From: Bartosz Golaszewski @ 2026-11-18 10:31 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Shawn Guo
  Cc: linux-arm-msm, linux-kernel, Bartosz Golaszewski

Enable the SGMII/SerDes PHY driver for the firmware-managed variant of
the Lemans platform. This module is required for ethernet to work on
sa8255p-ride.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 52a4f0b45707976590d2b5ed09427737e4e5c644..213445d7e3cfafd678bb1f5974a8dac46b679df8 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1671,6 +1671,7 @@ CONFIG_PHY_QCOM_USB_SNPS_FEMTO_V2=m
 CONFIG_PHY_QCOM_USB_HS_28NM=m
 CONFIG_PHY_QCOM_USB_SS=m
 CONFIG_PHY_QCOM_SGMII_ETH=m
+CONFIG_PHY_QCOM_SGMII_ETH_SCMI=m
 CONFIG_PHY_R8A779F0_ETHERNET_SERDES=y
 CONFIG_PHY_RCAR_GEN3_PCIE=y
 CONFIG_PHY_RCAR_GEN3_USB2=y

---
base-commit: 7cfbf79c66c63e807ea452abf0546e6f6d6833a6
change-id: 20261118-qcom-scmi-sgmii-phy-defconfig-a76311772311

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: defconfig: enable the SerDes PHY for Qualcomm SA8255p
  2026-11-18 10:31 [PATCH] arm64: defconfig: enable the SerDes PHY for Qualcomm SA8255p Bartosz Golaszewski
@ 2026-11-18 12:42 ` Krzysztof Kozlowski
  2026-11-18 12:51   ` Bartosz Golaszewski
  0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-18 12:42 UTC (permalink / raw)
  To: Bartosz Golaszewski, Bjorn Andersson, Konrad Dybcio, Abel Vesa,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Bartosz Golaszewski, Shawn Guo
  Cc: linux-arm-msm, linux-kernel

On 18/11/2026 11:31, Bartosz Golaszewski wrote:
> Enable the SGMII/SerDes PHY driver for the firmware-managed variant of
> the Lemans platform. This module is required for ethernet to work on

Which Lemans? This is a generic defconfig, not vendor specific.

> sa8255p-ride.
> 

`git grep` gives me only piece of a compatible, not even DTS. There is
no such board simply. We don't take changes for non-upstream boards.


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: defconfig: enable the SerDes PHY for Qualcomm SA8255p
  2026-11-18 12:42 ` Krzysztof Kozlowski
@ 2026-11-18 12:51   ` Bartosz Golaszewski
  2026-11-18 13:15     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 4+ messages in thread
From: Bartosz Golaszewski @ 2026-11-18 12:51 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Bartosz Golaszewski, Bjorn Andersson, Konrad Dybcio, Abel Vesa,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	linux-arm-msm, linux-kernel

On Wed, Nov 18, 2026 at 01:42:57PM +0100, Krzysztof Kozlowski wrote:
> On 18/11/2026 11:31, Bartosz Golaszewski wrote:
> > Enable the SGMII/SerDes PHY driver for the firmware-managed variant of
> > the Lemans platform. This module is required for ethernet to work on
> 
> Which Lemans? This is a generic defconfig, not vendor specific.
> 

SA8255p as per the subject line. In order to not repeat myself, I called
it "firmware-managed variant of Lemans". I feel like this is
nit-picking. It's pretty clear on which platform requires that driver.

> > sa8255p-ride.
> > 
> 
> `git grep` gives me only piece of a compatible, not even DTS. There is
> no such board simply. We don't take changes for non-upstream boards.
>

What do you mean? The full compatible is "qcom,sa8255p-ride", I dropped
the vendor prefix as this is a commit message and I mentioned it's
Qualcomm in the previous paragraph.

The .dts is now in next as:
  arch/arm64/boot/dts/qcom/lemans-sa8255p-ride.dts

Bart

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: defconfig: enable the SerDes PHY for Qualcomm SA8255p
  2026-11-18 12:51   ` Bartosz Golaszewski
@ 2026-11-18 13:15     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-18 13:15 UTC (permalink / raw)
  To: Bartosz Golaszewski
  Cc: Bartosz Golaszewski, Bjorn Andersson, Konrad Dybcio, Abel Vesa,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	linux-arm-msm, linux-kernel

On 18/11/2026 13:51, Bartosz Golaszewski wrote:
> On Wed, Nov 18, 2026 at 01:42:57PM +0100, Krzysztof Kozlowski wrote:
>> On 18/11/2026 11:31, Bartosz Golaszewski wrote:
>>> Enable the SGMII/SerDes PHY driver for the firmware-managed variant of
>>> the Lemans platform. This module is required for ethernet to work on
>>
>> Which Lemans? This is a generic defconfig, not vendor specific.
>>
> 
> SA8255p as per the subject line. In order to not repeat myself, I called
> it "firmware-managed variant of Lemans". I feel like this is
> nit-picking. It's pretty clear on which platform requires that driver.

No, it's not clear. Only you and Qualcomm knows what is Lemans. No one
else knows.

I repeated this feedback already 5 times this month and then every other
month as well.

> 
>>> sa8255p-ride.
>>>
>>
>> `git grep` gives me only piece of a compatible, not even DTS. There is
>> no such board simply. We don't take changes for non-upstream boards.
>>
> 
> What do you mean? The full compatible is "qcom,sa8255p-ride", I dropped
> the vendor prefix as this is a commit message and I mentioned it's
> Qualcomm in the previous paragraph.
> 
> The .dts is now in next as:
>   arch/arm64/boot/dts/qcom/lemans-sa8255p-ride.dts

OK, I looked at next from 13th Nov, so indeed a bit stalled.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-18 13:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 10:31 [PATCH] arm64: defconfig: enable the SerDes PHY for Qualcomm SA8255p Bartosz Golaszewski
2026-11-18 12:42 ` Krzysztof Kozlowski
2026-11-18 12:51   ` Bartosz Golaszewski
2026-11-18 13:15     ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox