The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: yuanjiey <yuanjie.yang@oss.qualcomm.com>
Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, tingwei.zhang@oss.qualcomm.com
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: qcom: Add HAMOA-IOT-COME board
Date: Mon, 3 Aug 2026 08:36:11 +0200	[thread overview]
Message-ID: <fe9d0f2b-3a86-4950-ae4e-fa5182706a38@kernel.org> (raw)
In-Reply-To: <anAx4kqb4PwEImeE@YUANJIEY2.ap.qualcomm.com>

On 03/08/2026 08:14, yuanjiey wrote:
> On Thu, Jul 30, 2026 at 12:23:56PM +0200, Krzysztof Kozlowski wrote:
>> On 30/07/2026 12:08, Krzysztof Kozlowski wrote:
>>> On 30/07/2026 11:54, yuanjiey wrote:
>>>> On Thu, Jul 30, 2026 at 08:51:40AM +0200, Krzysztof Kozlowski wrote:
>>>>> On Mon, Jul 27, 2026 at 03:07:16PM +0800, Yuanjie Yang wrote:
>>>>>> Document the device tree binding for the HAMOA-IOT-COME board based on
>>>>>> the Qualcomm X1E80100 SoC.
>>>>>>
>>>>>> The platform consists of a system-on-module (SoM) mounted on a carrier
>>>>>> board. The SoM integrates the core system functionality, including a
>>>>>> SiP containing the X1E80100 SoC and its supporting components.
>>>>>>
>>>>>> The COME SiP hardware is effectively the same as the SoM used on the
>>>>>
>>>>> Effectively the same or the same? I googled for "hamoa iot come" and it
>>>>> gives me zero results. Provide some URLs describing both.
>>>> The same.
>>>>
>>>>
>>>> Here is pdf about the "hamoa iot come" SiP and SoM
>>>> link: https://advdownload.advantech.com.cn/productfile/PIS/SOM-6820/file/SOM-6820_DS(052925)20250529110758.pdf
>>>>
>>>> The preliminary figure provides a complete overview of architecture, including the SiP, SoM.
>>>>
>>>> In Block Diagram
>>>> hamoa come Qualcomm X-Elite SiP Module is the SoM on haoma evk.
>>>
>>> I see on that PDF "SOM-6820", not "Hamoa IoT Come".
>>>
>>> I have an impression that all this and previous bindings and DTs did not
>>> match reality at all. Or did not match how upstream works with such
>>> hardware.
>>>
>>
>> Adding more: I did ask in the past to properly represent SoM and
>> carriers. I pointed to other examples how this is done correctly. I did
>> look now inside and found absolutely no reference of actual product
>> called "Hamoa IoT" or "Purwa IoT". For sure there is no "Hamoa IoT Come"
>> SoM (sometimes COMe appears).
> 
> I check the hamoa iot evk board page:
> https://docs.qualcomm.com/doc/80-77183-262/topic/Getting-started.html#get-familiar
> and 

It says it has "IQ-X7xxx module".

> purwa iot evk board page:
> https://docs.qualcomm.com/doc/80-80022-297/80-80022-297_REV_AC_Qualcomm_IQ-X_Series_Evaluation_Kit_-_Linux_Bringup_guide.pdf

And this is "IQ-X5xxx"

So how is this anyhow related to Hamoa IoT or Hamoa Iot Come?


> 
> And I see below info:
> 
> Dragonwing IQ-X7xxx EVK components:
> The kit includes the following components:
> Dragonwing IQ-X7xxx EVK mainboard
> "System in package (SiP) "
> 
> I think the current naming of hamoa-iot-som.dtsi and purwa-iot-som.dtsi in the
> Linux device tree is incorrect. They should be renamed to hamoa-iot-sip.dtsi
> and purwa-iot-sip.dtsi.

som/sip does not matter here. That's not what we discuss.


> 
> hamoa-iot-som.dtsi --> hamoa-iot-sip.dtsi
> purwa-iot-som.dtsi --> purwa-iot-sip.dtsi
> 
>> Look, this is a SoM:
>> https://www.toradex.com/computer-on-modules/verdin-arm-family/nxp-imx95
>>
>> And you can find corresponding bindings and DTS in tree.
>>
>> I refuse to accept more of this fake products trying to imitate well
>> known industry standards in their own way and effectively pushing some
>> downstream crap, just because that's how we do it in downstream.
>>
>> Unless you can present us with such product details matching what you
>> send, I will be NAK-ing these and future patches like that.
> 
> Thanks for your tips:
> 
> I check hamoa come som page:
> https://advdownload.advantech.com.cn/productfile/PIS/SOM-6820/file/SOM-6820_DS(052925)20250529110758.pdf
> and come board page:
> https://www.advantech.com.cn/zh-cn/products/1-fc23ff/som-db5830/mod_16b1a718-27d6-4a4c-8684-e8f2a8e9c57b
> 
> So I should rename come binding with real devices name:
> binding should be:
> 
>       - items:
>           - enum:
>               - hamoa-som6820-db5830.dts
>           - const: hamoa-som6820.dtsi

No clue what is this. But the links above are Advantech.



Best regards,
Krzysztof

  reply	other threads:[~2026-08-03  6:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27  7:07 [PATCH v2 0/2] Initial support for Qualcomm Hamoa IOT COME board Yuanjie Yang
2026-07-27  7:07 ` [PATCH v2 1/2] dt-bindings: arm: qcom: Add HAMOA-IOT-COME board Yuanjie Yang
2026-07-30  6:51   ` Krzysztof Kozlowski
2026-07-30  9:54     ` yuanjiey
2026-07-30 10:08       ` Krzysztof Kozlowski
2026-07-30 10:23         ` Krzysztof Kozlowski
2026-08-03  6:14           ` yuanjiey
2026-08-03  6:36             ` Krzysztof Kozlowski [this message]
2026-08-03  7:55               ` yuanjiey
2026-07-27  7:07 ` [PATCH v2 2/2] arm64: dts: qcom: Add base " Yuanjie Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe9d0f2b-3a86-4950-ae4e-fa5182706a38@kernel.org \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tingwei.zhang@oss.qualcomm.com \
    --cc=yuanjie.yang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox