From: David Laight <David.Laight@ACULAB.COM>
To: 'Alan Huang' <mmpgouride@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"rcu@vger.kernel.org" <rcu@vger.kernel.org>
Cc: "Paul E. McKenney" <paulmck@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"roman.gushchin@linux.dev" <roman.gushchin@linux.dev>
Subject: RE: Question about the barrier() in hlist_nulls_for_each_entry_rcu()
Date: Fri, 21 Jul 2023 11:51:39 +0000 [thread overview]
Message-ID: <fedf0448966b44d5b9146508265874fd@AcuMS.aculab.com> (raw)
In-Reply-To: <04C1E631-725C-47AD-9914-25D5CE04DFF4@gmail.com>
From: Alan Huang
> Sent: 20 July 2023 19:54
>
> I noticed a commit c87a124a5d5e(“net: force a reload of first item in hlist_nulls_for_each_entry_rcu”)
> and a related discussion [1].
Hmmm... that was all about the retry loop in ipv4/udp.c
AFAICT that retry got deleted by ca065d0c.
That also changes the list from hlist_nulls_xxx to hlist_xxx.
(I'm not sure of the difference)
This might be why we're seeing unexpected 'port unreachable' messages?
Quite why that has just started happening is another issue.
Most of the UDP sockets we create aren't 'connected' so I don't
believe they get moved between hash chains - just deleted.
The deletion should leave the hash chain intact.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2023-07-21 11:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 18:53 Question about the barrier() in hlist_nulls_for_each_entry_rcu() Alan Huang
2023-07-20 19:22 ` Eric Dumazet
2023-07-20 19:59 ` Alan Huang
2023-07-20 21:11 ` Eric Dumazet
2023-07-21 14:31 ` Alan Huang
2023-07-21 14:47 ` Eric Dumazet
2023-07-21 15:21 ` Alan Huang
2023-07-21 12:54 ` Joel Fernandes
2023-07-21 14:27 ` Alan Huang
2023-07-21 15:21 ` Joel Fernandes
2023-07-21 15:54 ` Alan Huang
2023-07-21 16:00 ` Joel Fernandes
2023-07-21 15:59 ` David Laight
2023-07-21 17:14 ` Joel Fernandes
2023-07-21 20:08 ` Alan Huang
2023-07-21 20:40 ` Alan Huang
2023-07-21 21:25 ` Alan Huang
2023-07-22 13:32 ` Alan Huang
2023-07-22 14:06 ` David Laight
2023-07-22 15:00 ` Alan Huang
2023-07-31 20:09 ` Paul E. McKenney
2023-08-03 13:40 ` Alan Huang
2023-08-03 13:53 ` Paul E. McKenney
2023-08-03 14:39 ` David Laight
2023-07-21 11:51 ` David Laight [this message]
2023-07-21 15:55 ` Alan Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fedf0448966b44d5b9146508265874fd@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmpgouride@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=roman.gushchin@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox