* [PATCH 0/3] arm64: dts: freescale: imx8mp-phycore: Add devicetree overlays
@ 2024-07-25 9:44 Yashwanth Varakala
2024-07-25 9:44 ` [PATCH 1/3] arm64: dts: freescale: imx8mp-phycore: Add no-rtc overlay Yashwanth Varakala
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Yashwanth Varakala @ 2024-07-25 9:44 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, festevam, robh, krzk+dt, conor+dt
Cc: imx, linux-arm-kernel, devicetree, linux-kernel, upstream,
y.varakala
Adding overlays for the phyboard imx8mp and updating them in
the Makefile.
Yashwanth Varakala (3):
arm64: dts: freescale: imx8mp-phycore: Add no-rtc overlay
arm64: boot: dts: freescale: Add no-spiflash overlay
arm64: dts: Add phyBOARD-Pollux dts for rpmsg
arch/arm64/boot/dts/freescale/Makefile | 6 ++
.../dts/freescale/imx8mp-phycore-no-rtc.dtso | 12 ++++
.../freescale/imx8mp-phycore-no-spiflash.dtso | 16 ++++++
.../dts/freescale/imx8mp-phycore-rpmsg.dtso | 57 +++++++++++++++++++
4 files changed, 91 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-phycore-no-rtc.dtso
create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-phycore-no-spiflash.dtso
create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-phycore-rpmsg.dtso
--
2.34.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/3] arm64: dts: freescale: imx8mp-phycore: Add no-rtc overlay
2024-07-25 9:44 [PATCH 0/3] arm64: dts: freescale: imx8mp-phycore: Add devicetree overlays Yashwanth Varakala
@ 2024-07-25 9:44 ` Yashwanth Varakala
2024-07-25 9:44 ` [PATCH 2/3] arm64: boot: dts: freescale: Add no-spiflash overlay Yashwanth Varakala
2024-07-25 9:44 ` [PATCH 3/3] arm64: dts: Add phyBOARD-Pollux dts for rpmsg Yashwanth Varakala
2 siblings, 0 replies; 8+ messages in thread
From: Yashwanth Varakala @ 2024-07-25 9:44 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, festevam, robh, krzk+dt, conor+dt
Cc: imx, linux-arm-kernel, devicetree, linux-kernel, upstream,
y.varakala
Add devicetree overlay to disable rtc for boards that are
not supported.
Signed-off-by: Yashwanth Varakala <y.varakala@phytec.de>
---
arch/arm64/boot/dts/freescale/Makefile | 2 ++
.../boot/dts/freescale/imx8mp-phycore-no-rtc.dtso | 12 ++++++++++++
2 files changed, 14 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-phycore-no-rtc.dtso
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index c1fca1fcedc5..8f41db93c3d9 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -175,7 +175,9 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-navqp.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb
imx8mp-phyboard-pollux-rdk-no-eth-dtbs += imx8mp-phyboard-pollux-rdk.dtb imx8mp-phycore-no-eth.dtbo
+imx8mp-phyboard-pollux-rdk-no-rtc-dtbs += imx8mp-phyboard-pollux-rdk.dtb imx8mp-phycore-no-rtc.dtbo
dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-no-eth.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-no-rtc.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-hdmi.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-lt6.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-mi1010ait-1cp1.dtb
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phycore-no-rtc.dtso b/arch/arm64/boot/dts/freescale/imx8mp-phycore-no-rtc.dtso
new file mode 100644
index 000000000000..396ffd9951b8
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mp-phycore-no-rtc.dtso
@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2024 PHYTEC Messtechnik GmbH
+ * Author: Cem Tenruh <c.tenruh@phytec.de>
+ */
+
+/dts-v1/;
+/plugin/;
+
+&rv3028 {
+ status = "disabled";
+};
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/3] arm64: boot: dts: freescale: Add no-spiflash overlay
2024-07-25 9:44 [PATCH 0/3] arm64: dts: freescale: imx8mp-phycore: Add devicetree overlays Yashwanth Varakala
2024-07-25 9:44 ` [PATCH 1/3] arm64: dts: freescale: imx8mp-phycore: Add no-rtc overlay Yashwanth Varakala
@ 2024-07-25 9:44 ` Yashwanth Varakala
2024-07-25 9:44 ` [PATCH 3/3] arm64: dts: Add phyBOARD-Pollux dts for rpmsg Yashwanth Varakala
2 siblings, 0 replies; 8+ messages in thread
From: Yashwanth Varakala @ 2024-07-25 9:44 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, festevam, robh, krzk+dt, conor+dt
Cc: imx, linux-arm-kernel, devicetree, linux-kernel, upstream,
y.varakala
Add devicetree overlay to disable SPI NOR if the module does
not supports or not equipped with SPI NOR flash.
Signed-off-by: Yashwanth Varakala <y.varakala@phytec.de>
---
arch/arm64/boot/dts/freescale/Makefile | 2 ++
.../freescale/imx8mp-phycore-no-spiflash.dtso | 16 ++++++++++++++++
2 files changed, 18 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-phycore-no-spiflash.dtso
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 8f41db93c3d9..dedea4b5c319 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -176,8 +176,10 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-navqp.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb
imx8mp-phyboard-pollux-rdk-no-eth-dtbs += imx8mp-phyboard-pollux-rdk.dtb imx8mp-phycore-no-eth.dtbo
imx8mp-phyboard-pollux-rdk-no-rtc-dtbs += imx8mp-phyboard-pollux-rdk.dtb imx8mp-phycore-no-rtc.dtbo
+imx8mp-phyboard-pollux-rdk-no-spiflash-dtbs += imx8mp-phyboard-pollux-rdk.dtb imx8mp-phycore-no-spiflash.dtbo
dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-no-eth.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-no-rtc.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-no-spiflash.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-hdmi.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-lt6.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-mi1010ait-1cp1.dtb
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phycore-no-spiflash.dtso b/arch/arm64/boot/dts/freescale/imx8mp-phycore-no-spiflash.dtso
new file mode 100644
index 000000000000..95329282d559
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mp-phycore-no-spiflash.dtso
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2024 PHYTEC Messtechnik GmbH
+ * Author: Cem Tenruh <c.tenruh@phytec.de>
+ */
+
+/dts-v1/;
+/plugin/;
+
+&flexspi {
+ status = "disabled";
+};
+
+&som_flash {
+ status = "disabled";
+};
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/3] arm64: dts: Add phyBOARD-Pollux dts for rpmsg
2024-07-25 9:44 [PATCH 0/3] arm64: dts: freescale: imx8mp-phycore: Add devicetree overlays Yashwanth Varakala
2024-07-25 9:44 ` [PATCH 1/3] arm64: dts: freescale: imx8mp-phycore: Add no-rtc overlay Yashwanth Varakala
2024-07-25 9:44 ` [PATCH 2/3] arm64: boot: dts: freescale: Add no-spiflash overlay Yashwanth Varakala
@ 2024-07-25 9:44 ` Yashwanth Varakala
2024-07-26 9:19 ` Krzysztof Kozlowski
2024-08-01 2:27 ` Peng Fan
2 siblings, 2 replies; 8+ messages in thread
From: Yashwanth Varakala @ 2024-07-25 9:44 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, festevam, robh, krzk+dt, conor+dt
Cc: imx, linux-arm-kernel, devicetree, linux-kernel, upstream,
y.varakala
Adds a devicetree containing reserved memory regions used for intercore
communication between A53 and M7 cores.
Signed-off-by: Yashwanth Varakala <y.varakala@phytec.de>
---
arch/arm64/boot/dts/freescale/Makefile | 2 +
.../dts/freescale/imx8mp-phycore-rpmsg.dtso | 57 +++++++++++++++++++
2 files changed, 59 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-phycore-rpmsg.dtso
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index dedea4b5c319..80cc87d50301 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -177,9 +177,11 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb
imx8mp-phyboard-pollux-rdk-no-eth-dtbs += imx8mp-phyboard-pollux-rdk.dtb imx8mp-phycore-no-eth.dtbo
imx8mp-phyboard-pollux-rdk-no-rtc-dtbs += imx8mp-phyboard-pollux-rdk.dtb imx8mp-phycore-no-rtc.dtbo
imx8mp-phyboard-pollux-rdk-no-spiflash-dtbs += imx8mp-phyboard-pollux-rdk.dtb imx8mp-phycore-no-spiflash.dtbo
+imx8mp-phyboard-pollux-rdk-rpmsg-dtbs += imx8mp-phyboard-pollux-rdk.dtb imx8mp-phycore-rpmsg.dtbo
dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-no-eth.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-no-rtc.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-no-spiflash.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-rpmsg.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-hdmi.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-lt6.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-mi1010ait-1cp1.dtb
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phycore-rpmsg.dtso b/arch/arm64/boot/dts/freescale/imx8mp-phycore-rpmsg.dtso
new file mode 100644
index 000000000000..a5694f3aecaa
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mp-phycore-rpmsg.dtso
@@ -0,0 +1,57 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2024 PHYTEC Messtechnik GmbH
+ * Author: Dominik Haller <d.haller@phytec.de>
+ * Cem Tenruh <c.tenruh@phytec.de>
+ */
+
+/dts-v1/;
+/plugin/;
+
+#include <dt-bindings/clock/imx8mp-clock.h>
+
+&{/} {
+ imx8mp-cm7 {
+ compatible = "fsl,imx8mn-cm7";
+ clocks = <&clk IMX8MP_CLK_M7_DIV>;
+ mboxes = <&mu 0 1
+ &mu 1 1
+ &mu 3 1>;
+ mbox-names = "tx", "rx", "rxdb";
+ memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>, <&rsc_table>;
+ rsc-da = <0x55000000>;
+ status = "okay";
+ };
+
+ reserved-memory {
+ ranges;
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ m7_reserved: m7@0x80000000 {
+ no-map;
+ reg = <0 0x80000000 0 0x1000000>;
+ };
+
+ rsc_table: rsc_table@550ff000 {
+ no-map;
+ reg = <0 0x550ff000 0 0x1000>;
+ };
+
+ vdevbuffer: vdevbuffer@55400000 {
+ compatible = "shared-dma-pool";
+ no-map;
+ reg = <0 0x55400000 0 0x100000>;
+ };
+
+ vdev0vring0: vdev0vring0@55000000 {
+ no-map;
+ reg = <0 0x55000000 0 0x8000>;
+ };
+
+ vdev0vring1: vdev0vring1@55008000 {
+ no-map;
+ reg = <0 0x55008000 0 0x8000>;
+ };
+ };
+};
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] arm64: dts: Add phyBOARD-Pollux dts for rpmsg
2024-07-25 9:44 ` [PATCH 3/3] arm64: dts: Add phyBOARD-Pollux dts for rpmsg Yashwanth Varakala
@ 2024-07-26 9:19 ` Krzysztof Kozlowski
2024-08-01 2:27 ` Peng Fan
1 sibling, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-07-26 9:19 UTC (permalink / raw)
To: Yashwanth Varakala, shawnguo, s.hauer, kernel, festevam, robh,
krzk+dt, conor+dt
Cc: imx, linux-arm-kernel, devicetree, linux-kernel, upstream
On 25/07/2024 11:44, Yashwanth Varakala wrote:
> Adds a devicetree containing reserved memory regions used for intercore
> communication between A53 and M7 cores.
>
> Signed-off-by: Yashwanth Varakala <y.varakala@phytec.de>
> ---
> arch/arm64/boot/dts/freescale/Makefile | 2 +
> .../dts/freescale/imx8mp-phycore-rpmsg.dtso | 57 +++++++++++++++++++
> 2 files changed, 59 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-phycore-rpmsg.dtso
>
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index dedea4b5c319..80cc87d50301 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -177,9 +177,11 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb
> imx8mp-phyboard-pollux-rdk-no-eth-dtbs += imx8mp-phyboard-pollux-rdk.dtb imx8mp-phycore-no-eth.dtbo
> imx8mp-phyboard-pollux-rdk-no-rtc-dtbs += imx8mp-phyboard-pollux-rdk.dtb imx8mp-phycore-no-rtc.dtbo
> imx8mp-phyboard-pollux-rdk-no-spiflash-dtbs += imx8mp-phyboard-pollux-rdk.dtb imx8mp-phycore-no-spiflash.dtbo
> +imx8mp-phyboard-pollux-rdk-rpmsg-dtbs += imx8mp-phyboard-pollux-rdk.dtb imx8mp-phycore-rpmsg.dtbo
> dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-no-eth.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-no-rtc.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-no-spiflash.dtb
> +dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-rpmsg.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-hdmi.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-lt6.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-mi1010ait-1cp1.dtb
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phycore-rpmsg.dtso b/arch/arm64/boot/dts/freescale/imx8mp-phycore-rpmsg.dtso
> new file mode 100644
> index 000000000000..a5694f3aecaa
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-phycore-rpmsg.dtso
> @@ -0,0 +1,57 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2024 PHYTEC Messtechnik GmbH
> + * Author: Dominik Haller <d.haller@phytec.de>
> + * Cem Tenruh <c.tenruh@phytec.de>
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +#include <dt-bindings/clock/imx8mp-clock.h>
> +
> +&{/} {
> + imx8mp-cm7 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "fsl,imx8mn-cm7";
> + clocks = <&clk IMX8MP_CLK_M7_DIV>;
> + mboxes = <&mu 0 1
> + &mu 1 1
> + &mu 3 1>;
That's one or there entries? look wrong.
> + mbox-names = "tx", "rx", "rxdb";
> + memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>, <&rsc_table>;
> + rsc-da = <0x55000000>;
> + status = "okay";
Why? Did you disable it anywhere? You add a new node.
> + };
> +
> + reserved-memory {
> + ranges;
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + m7_reserved: m7@0x80000000 {
> + no-map;
> + reg = <0 0x80000000 0 0x1000000>;
> + };
> +
> + rsc_table: rsc_table@550ff000 {
Please follow DTS coding style... This applies to all your contributions.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 3/3] arm64: dts: Add phyBOARD-Pollux dts for rpmsg
2024-07-25 9:44 ` [PATCH 3/3] arm64: dts: Add phyBOARD-Pollux dts for rpmsg Yashwanth Varakala
2024-07-26 9:19 ` Krzysztof Kozlowski
@ 2024-08-01 2:27 ` Peng Fan
2024-08-07 10:34 ` Yashwanth Varakala
1 sibling, 1 reply; 8+ messages in thread
From: Peng Fan @ 2024-08-01 2:27 UTC (permalink / raw)
To: Yashwanth Varakala, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org
Cc: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
upstream@lists.phytec.de
> Subject: [PATCH 3/3] arm64: dts: Add phyBOARD-Pollux dts for rpmsg
>
> Adds a devicetree containing reserved memory regions used for
> intercore communication between A53 and M7 cores.
>
> Signed-off-by: Yashwanth Varakala <y.varakala@phytec.de>
> ---
> arch/arm64/boot/dts/freescale/Makefile | 2 +
> .../dts/freescale/imx8mp-phycore-rpmsg.dtso | 57
> +++++++++++++++++++
> 2 files changed, 59 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-
> phycore-rpmsg.dtso
>
> diff --git a/arch/arm64/boot/dts/freescale/Makefile
> b/arch/arm64/boot/dts/freescale/Makefile
> index dedea4b5c319..80cc87d50301 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -177,9 +177,11 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-
> phyboard-pollux-rdk.dtb imx8mp-phyboard-pollux-rdk-no-eth-dtbs +=
> imx8mp-phyboard-pollux-rdk.dtb imx8mp-phycore-no-eth.dtbo
> imx8mp-phyboard-pollux-rdk-no-rtc-dtbs += imx8mp-phyboard-pollux-
> rdk.dtb imx8mp-phycore-no-rtc.dtbo imx8mp-phyboard-pollux-rdk-no-
> spiflash-dtbs += imx8mp-phyboard-pollux-rdk.dtb imx8mp-phycore-no-
> spiflash.dtbo
> +imx8mp-phyboard-pollux-rdk-rpmsg-dtbs += imx8mp-phyboard-
> pollux-rdk.dtb
> +imx8mp-phycore-rpmsg.dtbo
> dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-no-
> eth.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-no-rtc.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-no-
> spiflash.dtb
> +dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-
> rpmsg.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-hdmi.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-lt6.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-mi1010ait-1cp1.dtb
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phycore-
> rpmsg.dtso b/arch/arm64/boot/dts/freescale/imx8mp-phycore-
> rpmsg.dtso
> new file mode 100644
> index 000000000000..a5694f3aecaa
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-phycore-rpmsg.dtso
> @@ -0,0 +1,57 @@
> +// SPDX-License-Identifier: GPL-2.0
Dual license is better device tree.
> +/*
> + * Copyright (C) 2024 PHYTEC Messtechnik GmbH
> + * Author: Dominik Haller <d.haller@phytec.de>
> + * Cem Tenruh <c.tenruh@phytec.de>
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +#include <dt-bindings/clock/imx8mp-clock.h>
> +
> +&{/} {
> + imx8mp-cm7 {
> + compatible = "fsl,imx8mn-cm7";
> + clocks = <&clk IMX8MP_CLK_M7_DIV>;
> + mboxes = <&mu 0 1
> + &mu 1 1
> + &mu 3 1>;
mboxes = <&mu1 0 1>,
<&mu1 1 1>,
<&mu1 3 1>;
> + mbox-names = "tx", "rx", "rxdb";
> + memory-region = <&vdevbuffer>, <&vdev0vring0>,
> <&vdev0vring1>, <&rsc_table>;
> + rsc-da = <0x55000000>;
Drop this "rsc-da".
> + status = "okay";
Drop it, default is "okay".
> + };
> +
> + reserved-memory {
> + ranges;
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + m7_reserved: m7@0x80000000 {
> + no-map;
> + reg = <0 0x80000000 0 0x1000000>;
> + };
> +
> + rsc_table: rsc_table@550ff000 {
"rsc-table@550ff000". Seems you not test this patch with linux
remoteproc, otherwise you will see vring not set up.
Regards,
Peng.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] arm64: dts: Add phyBOARD-Pollux dts for rpmsg
2024-08-01 2:27 ` Peng Fan
@ 2024-08-07 10:34 ` Yashwanth Varakala
2024-08-08 3:13 ` Peng Fan
0 siblings, 1 reply; 8+ messages in thread
From: Yashwanth Varakala @ 2024-08-07 10:34 UTC (permalink / raw)
To: kernel@pengutronix.de, s.hauer@pengutronix.de, peng.fan@nxp.com,
robh@kernel.org, shawnguo@kernel.org, krzk+dt@kernel.org,
festevam@gmail.com, conor+dt@kernel.org
Cc: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
PHYTEC Upstream
Hello Peng,
On Thu, 2024-08-01 at 02:27 +0000, Peng Fan wrote:
> > Subject: [PATCH 3/3] arm64: dts: Add phyBOARD-Pollux dts for rpmsg
> >
> > Adds a devicetree containing reserved memory regions used for
> > intercore communication between A53 and M7 cores.
> >
> > Signed-off-by: Yashwanth Varakala <y.varakala@phytec.de>
> > ---
> > arch/arm64/boot/dts/freescale/Makefile | 2 +
> > .../dts/freescale/imx8mp-phycore-rpmsg.dtso | 57
> > +++++++++++++++++++
> > 2 files changed, 59 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-
> > phycore-rpmsg.dtso
> >
> > diff --git a/arch/arm64/boot/dts/freescale/Makefile
> > b/arch/arm64/boot/dts/freescale/Makefile
> > index dedea4b5c319..80cc87d50301 100644
> > --- a/arch/arm64/boot/dts/freescale/Makefile
> > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > @@ -177,9 +177,11 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-
> > phyboard-pollux-rdk.dtb imx8mp-phyboard-pollux-rdk-no-eth-dtbs +=
> > imx8mp-phyboard-pollux-rdk.dtb imx8mp-phycore-no-eth.dtbo
> > imx8mp-phyboard-pollux-rdk-no-rtc-dtbs += imx8mp-phyboard-pollux-
> > rdk.dtb imx8mp-phycore-no-rtc.dtbo imx8mp-phyboard-pollux-rdk-no-
> > spiflash-dtbs += imx8mp-phyboard-pollux-rdk.dtb imx8mp-phycore-no-
> > spiflash.dtbo
> > +imx8mp-phyboard-pollux-rdk-rpmsg-dtbs += imx8mp-phyboard-
> > pollux-rdk.dtb
> > +imx8mp-phycore-rpmsg.dtbo
> > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-no-
> > eth.dtb
> > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-no-rtc.dtb
> > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-no-
> > spiflash.dtb
> > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-
> > rpmsg.dtb
> > dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-hdmi.dtb
> > dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-lt6.dtb
> > dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-mi1010ait-1cp1.dtb
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phycore-
> > rpmsg.dtso b/arch/arm64/boot/dts/freescale/imx8mp-phycore-
> > rpmsg.dtso
> > new file mode 100644
> > index 000000000000..a5694f3aecaa
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-phycore-rpmsg.dtso
> > @@ -0,0 +1,57 @@
> > +// SPDX-License-Identifier: GPL-2.0
>
> Dual license is better device tree.
>
> > +/*
> > + * Copyright (C) 2024 PHYTEC Messtechnik GmbH
> > + * Author: Dominik Haller <d.haller@phytec.de>
> > + * Cem Tenruh <c.tenruh@phytec.de>
> > + */
> > +
> > +/dts-v1/;
> > +/plugin/;
> > +
> > +#include <dt-bindings/clock/imx8mp-clock.h>
> > +
> > +&{/} {
> > + imx8mp-cm7 {
> > + compatible = "fsl,imx8mn-cm7";
> > + clocks = <&clk IMX8MP_CLK_M7_DIV>;
> > + mboxes = <&mu 0 1
> > + &mu 1 1
> > + &mu 3 1>;
>
> mboxes = <&mu1 0
> 1>,
>
> <&mu1 1
> 1>,
>
> <&mu1 3 1>;
Thank you for the feedback. I checked and found only mu and mu2 labels
of mailboxes are present. mu1 is not used in imx8mp.dtsi. Can you
please tell me why I have to use mu1 here?
>
> > + mbox-names = "tx", "rx", "rxdb";
> > + memory-region = <&vdevbuffer>, <&vdev0vring0>,
> > <&vdev0vring1>, <&rsc_table>;
> > + rsc-da = <0x55000000>;
>
> Drop this "rsc-da".
>
> > + status = "okay";
>
> Drop it, default is "okay".
>
> > + };
> > +
> > + reserved-memory {
> > + ranges;
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > +
> > + m7_reserved: m7@0x80000000 {
> > + no-map;
> > + reg = <0 0x80000000 0 0x1000000>;
> > + };
> > +
> > + rsc_table: rsc_table@550ff000 {
>
> "rsc-table@550ff000". Seems you not test this patch with linux
> remoteproc, otherwise you will see vring not set up.
>
> Regards,
> Peng.
--
-
Regards,
Yashwanth
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 3/3] arm64: dts: Add phyBOARD-Pollux dts for rpmsg
2024-08-07 10:34 ` Yashwanth Varakala
@ 2024-08-08 3:13 ` Peng Fan
0 siblings, 0 replies; 8+ messages in thread
From: Peng Fan @ 2024-08-08 3:13 UTC (permalink / raw)
To: Yashwanth Varakala, kernel@pengutronix.de, s.hauer@pengutronix.de,
robh@kernel.org, shawnguo@kernel.org, krzk+dt@kernel.org,
festevam@gmail.com, conor+dt@kernel.org
Cc: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
PHYTEC Upstream
> Subject: Re: [PATCH 3/3] arm64: dts: Add phyBOARD-Pollux dts for
> rpmsg
>
> Hello Peng,
>
> On Thu, 2024-08-01 at 02:27 +0000, Peng Fan wrote:
> > > Subject: [PATCH 3/3] arm64: dts: Add phyBOARD-Pollux dts for
> rpmsg
> > >
> > > Adds a devicetree containing reserved memory regions used for
> > > intercore communication between A53 and M7 cores.
> > >
> > > Signed-off-by: Yashwanth Varakala <y.varakala@phytec.de>
> > > ---
> > > arch/arm64/boot/dts/freescale/Makefile | 2 +
> > > .../dts/freescale/imx8mp-phycore-rpmsg.dtso | 57
> > > +++++++++++++++++++
> > > 2 files changed, 59 insertions(+)
> > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-
> > > phycore-rpmsg.dtso
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/Makefile
> > > b/arch/arm64/boot/dts/freescale/Makefile
> > > index dedea4b5c319..80cc87d50301 100644
> > > --- a/arch/arm64/boot/dts/freescale/Makefile
> > > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > > @@ -177,9 +177,11 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-
> > > phyboard-pollux-rdk.dtb imx8mp-phyboard-pollux-rdk-no-eth-dtbs
> +=
> > > imx8mp-phyboard-pollux-rdk.dtb imx8mp-phycore-no-eth.dtbo
> > > imx8mp-phyboard-pollux-rdk-no-rtc-dtbs += imx8mp-phyboard-
> pollux-
> > > rdk.dtb imx8mp-phycore-no-rtc.dtbo imx8mp-phyboard-pollux-
> rdk-no-
> > > spiflash-dtbs += imx8mp-phyboard-pollux-rdk.dtb imx8mp-phycore-
> no-
> > > spiflash.dtbo
> > > +imx8mp-phyboard-pollux-rdk-rpmsg-dtbs += imx8mp-phyboard-
> > > pollux-rdk.dtb
> > > +imx8mp-phycore-rpmsg.dtbo
> > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-no-
> eth.dtb
> > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-no-
> rtc.dtb
> > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-no-
> > > spiflash.dtb
> > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk-
> > > rpmsg.dtb
> > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-hdmi.dtb
> > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-lt6.dtb
> > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-mi1010ait-
> 1cp1.dtb
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phycore-
> > > rpmsg.dtso b/arch/arm64/boot/dts/freescale/imx8mp-phycore-
> > > rpmsg.dtso
> > > new file mode 100644
> > > index 000000000000..a5694f3aecaa
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-phycore-rpmsg.dtso
> > > @@ -0,0 +1,57 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> >
> > Dual license is better device tree.
> >
> > > +/*
> > > + * Copyright (C) 2024 PHYTEC Messtechnik GmbH
> > > + * Author: Dominik Haller <d.haller@phytec.de>
> > > + * Cem Tenruh <c.tenruh@phytec.de> */
> > > +
> > > +/dts-v1/;
> > > +/plugin/;
> > > +
> > > +#include <dt-bindings/clock/imx8mp-clock.h>
> > > +
> > > +&{/} {
> > > + imx8mp-cm7 {
> > > + compatible = "fsl,imx8mn-cm7";
> > > + clocks = <&clk IMX8MP_CLK_M7_DIV>;
> > > + mboxes = <&mu 0 1
> > > + &mu 1 1
> > > + &mu 3 1>;
> >
> > mboxes = <&mu1 0
> > 1>,
> >
> > <&mu1 1
> > 1>,
> >
> > <&mu1 3 1>;
> Thank you for the feedback. I checked and found only mu and mu2
> labels of mailboxes are present. mu1 is not used in imx8mp.dtsi. Can
> you please tell me why I have to use mu1 here?
I just copy and paste what imx8mp-evk use to here. You need
update according to your usage.
Regards,
Peng.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-08-08 3:13 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-25 9:44 [PATCH 0/3] arm64: dts: freescale: imx8mp-phycore: Add devicetree overlays Yashwanth Varakala
2024-07-25 9:44 ` [PATCH 1/3] arm64: dts: freescale: imx8mp-phycore: Add no-rtc overlay Yashwanth Varakala
2024-07-25 9:44 ` [PATCH 2/3] arm64: boot: dts: freescale: Add no-spiflash overlay Yashwanth Varakala
2024-07-25 9:44 ` [PATCH 3/3] arm64: dts: Add phyBOARD-Pollux dts for rpmsg Yashwanth Varakala
2024-07-26 9:19 ` Krzysztof Kozlowski
2024-08-01 2:27 ` Peng Fan
2024-08-07 10:34 ` Yashwanth Varakala
2024-08-08 3:13 ` Peng Fan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox