From: Andreas Schwab <schwab@suse.de>
To: kaih@khms.westfalen.de (Kai Henningsen)
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Athlon/Opteron Prefetch Fix for 2.6.0test5 + numbers
Date: Fri, 19 Sep 2003 12:02:56 +0200 [thread overview]
Message-ID: <jeoexhqenj.fsf@sykes.suse.de> (raw)
In-Reply-To: <8uAuunHHw-B@khms.westfalen.de> (Kai Henningsen's message of "19 Sep 2003 08:55:00 +0200")
kaih@khms.westfalen.de (Kai Henningsen) writes:
> ak@suse.de (Andi Kleen) wrote on 17.09.03 in <20030917211200.GA5997@wotan.suse.de>:
>
>> On Wed, Sep 17, 2003 at 01:50:59PM -0700, Linus Torvalds wrote:
>
>> > Also, you do things like comparing pointers for less/greater than, and at
>> > least some versions of gcc has done that wrong - using signed comparisons.
>>
>> Really? Is that any version we still support (2.95+) ?
>> It is certainly legal ISO-C. I changed it for now.
>
> It certainly is *not* legal ISO C, and never was.
Certainly the kernel isn't using ISO C, and never will.
IMHO you can just compare two pointers to char in GNU C and expect to get
a meaningful result. I think the bug Linus was thinking of was some
problems with counting loops where gcc transformed the index variable into
a pointer, but then got the terminating comparison wrong.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
prev parent reply other threads:[~2003-09-19 10:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-17 2:22 [PATCH] Athlon/Opteron Prefetch Fix for 2.6.0test5 + numbers Andi Kleen
2003-09-17 2:44 ` Andrew Morton
2003-09-17 3:25 ` Andi Kleen
2003-09-17 4:53 ` Nick Piggin
2003-09-17 5:08 ` Andrew Morton
2003-09-17 5:19 ` Nick Piggin
2003-09-17 7:15 ` Dave Hansen
2003-09-17 5:26 ` Andi Kleen
2003-09-17 5:44 ` Nick Piggin
2003-09-17 19:53 ` Linus Torvalds
2003-09-17 20:21 ` Andi Kleen
2003-09-17 20:50 ` Linus Torvalds
2003-09-17 21:12 ` Andi Kleen
2003-09-18 15:38 ` Jamie Lokier
2003-09-18 16:04 ` Jamie Lokier
2003-09-18 17:06 ` Andi Kleen
2003-09-18 19:48 ` Jamie Lokier
2003-09-19 6:55 ` Kai Henningsen
2003-09-19 10:02 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jeoexhqenj.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=kaih@khms.westfalen.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox