Regarding select() on PPC

Regarding select() on PPC

[Halesh S]

Hi all,

Please find the below testcase.

#include <stdio.h>
#include <sys/time.h>
#include <sys/types.h>
#include <unistd.h>
#include <fcntl.h>
#include <string.h>
#include <time.h>
#include <errno.h>
#include <stdlib.h>

int main()
{

 int fd;
 fd_set rfds;
 struct timeval tv;
 int ret_val;

 if ((fd = open("test_file", O_RDWR|O_CREAT, 0664)) < 0)
  {
    printf("Open failed\n");
  }

  FD_ZERO(&rfds);
  FD_SET(fd, &rfds);

  /* Wait up to five seconds. */
  tv.tv_sec = 1;
  tv.tv_usec = 0;

  if ( (ret_val = select(-1, &rfds, NULL, NULL, &tv)) < 0)
  {
    if (errno == EINVAL)
      printf("OK\n");
    else
      printf("Not OK, Got errno %d\n", errno);
  }
  exit(0);
}


For negetive value of n (first argument to select) select fails with
EINVAL error,

But for the same when I tested for PowerPC it was giving EFAULT, 
Its on 2.6.16 kernel.

Please let me know, If this is fixed or it's a issue in PPC.
For other archs its working fine.


Thanks,
Halesh

Re: Regarding select() on PPC

[Halesh S]

Halesh S <halesh.sadashiv <at> ap.sony.com> writes:

> 
> Hi all,
> 
> Please find the below testcase.
> 
> #include <stdio.h>
> #include <sys/time.h>
> #include <sys/types.h>
> #include <unistd.h>
> #include <fcntl.h>
> #include <string.h>
> #include <time.h>
> #include <errno.h>
> #include <stdlib.h>
> 
> int main()
> {
> 
>  int fd;
>  fd_set rfds;
>  struct timeval tv;
>  int ret_val;
> 
>  if ((fd = open("test_file", O_RDWR|O_CREAT, 0664)) < 0)
>   {
>     printf("Open failed\n");
>   }
> 
>   FD_ZERO(&rfds);
>   FD_SET(fd, &rfds);
> 
>   /* Wait up to five seconds. */
>   tv.tv_sec = 1;
>   tv.tv_usec = 0;
> 
>   if ( (ret_val = select(-1, &rfds, NULL, NULL, &tv)) < 0)
>   {
>     if (errno == EINVAL)
>       printf("OK\n");
>     else
>       printf("Not OK, Got errno %d\n", errno);
>   }
>   exit(0);
> }
> 
> For negetive value of n (first argument to select) select fails with
> EINVAL error,
> 
> But for the same when I tested for PowerPC it was giving EFAULT, 
> Its on 2.6.16 kernel.
> 
> Please let me know, If this is fixed or it's a issue in PPC.
> For other archs its working fine.
> 
> Thanks,
> Halesh
> 
> 


On further investigation found, the above problem occurs only in PPC32.

Because select()->ppc_select()->sys_select() only for PPC32.

In the file powerpc/kernel/syscalls.c, 

#ifdef CONFIG_PPC32
/*
* Due to some executables calling the wrong select we sometimes
* get wrong args.  This determines how the args are being passed
* (a single ptr to them all args passed) then calls
* sys_select() with the appropriate args. -- Cort
*/
int
ppc_select(int n, fd_set __user *inp, fd_set __user *outp, fd_set __user *exp, 
struct timeval __user *tvp)
{
        if ( (unsigned long)n >= 4096 )
        {
                unsigned long __user *buffer = (unsigned long __user *)n;
                if (!access_ok(VERIFY_READ, buffer, 5*sizeof(unsigned long))
                   || __get_user(n, buffer)
                   || __get_user(inp, ((fd_set __user * __user *)(buffer+1)))
                   || __get_user(outp, ((fd_set  __user * __user *)(buffer+2)))
                   || __get_user(exp, ((fd_set  __user * __user *)(buffer+3)))
                   || __get_user(tvp, ((struct timeval  __user * __user *)
(buffer+4))))
                   return -EFAULT;
        }
        return sys_select(n, inp, outp, exp, tvp);
}
#endif


What is the purpose of Argument check only for PPC32, is ther any specific 
reason? Please let me know if so. Comments were not enough to understad the 
actual reason reas for me.

On all archs I have checked like PPC64, ARM, i686 with invalid 'n' val returns 
EINVAL, execpet on PPC32, this needs to be fixed ??

either man page / return value in kernel source.

 - return -EFAULT
 + return -EINVAL

Please let me know regarding this issue.


Thanks,
Halesh

Re: Regarding select() on PPC

[Andreas Schwab]

Halesh S <halesh.sadashiv@ap.sony.com> writes:

> What is the purpose of Argument check only for PPC32, is ther any specific 
> reason?

Probably long obsolete, it predates linux 2.2.0.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Regarding select() on PPC

[Halesh S]

Andreas Schwab <schwab <at> suse.de> writes:

> 
> Halesh S <halesh.sadashiv <at> ap.sony.com> writes:
> 
> > What is the purpose of Argument check only for PPC32, is ther any specific 
> > reason?
> 
> Probably long obsolete, it predates linux 2.2.0.

  Than do you mean by this is not required in later versions.

> 
> Andreas.
> 

Thanks,
Halesh

Re: Regarding select() on PPC

[Halesh S]

Halesh S <halesh.sadashiv <at> ap.sony.com> writes:

> 
> Andreas Schwab <schwab <at> suse.de> writes:
> 
> > 
> > Halesh S <halesh.sadashiv <at> ap.sony.com> writes:
> > 
> > > What is the purpose of Argument check only for PPC32, is ther any 
specific 
> > > reason?
> > 
> > Probably long obsolete, it predates linux 2.2.0.
> 
>   Than do you mean by this is not required in later versions.
> 
> > 
> > Andreas.
> > 
> 
> Thanks,
> Halesh
> 
> 


Halesh S <halesh.sadashiv <at> ap.sony.com> writes:

> 
> Andreas Schwab <schwab <at> suse.de> writes:
> 
> > 
> > Halesh S <halesh.sadashiv <at> ap.sony.com> writes:
> > 
> > > What is the purpose of Argument check only for PPC32, is ther any 
specific 
> > > reason?
> > 
> > Probably long obsolete, it predates linux 2.2.0.
> 
>   Than do you mean by this is not required in later versions.
> 
> > 
> > Andreas.
> > 
> 
> Thanks,
> Halesh
> 
> 

Please check this patch be applied for latest linux kernel??

--- arch/powerpc/kernel.old/syscalls.c  2008-09-22 20:47:06.000000000 +0530
+++ arch/powerpc/kernel/syscalls.c      2008-09-23 09:38:31.841327576 +0530
@@ -203,25 +203,13 @@

 #ifdef CONFIG_PPC32
 /*
- * Due to some executables calling the wrong select we sometimes
- * get wrong args.  This determines how the args are being passed
- * (a single ptr to them all args passed) then calls
- * sys_select() with the appropriate args. -- Cort
+ * The argument checking is long obselete, the code was carried from
+ * kernel version 2.2.0, so removing obselete code and directly call
+ * to sys_select()
  */
 int
 ppc_select(int n, fd_set __user *inp, fd_set __user *outp, fd_set __user 
*exp, struct timeval __user *tvp)
 {
-   if ( (unsigned long)n >= 4096 )
-   {
-       unsigned long __user *buffer = (unsigned long __user *)n;
-       if (!access_ok(VERIFY_READ, buffer, 5*sizeof(unsigned long))
-           || __get_user(n, buffer)
-           || __get_user(inp, ((fd_set __user * __user *)(buffer+1)))
-           || __get_user(outp, ((fd_set  __user * __user *)(buffer+2)))
-           || __get_user(exp, ((fd_set  __user * __user *)(buffer+3)))
-           || __get_user(tvp, ((struct timeval  __user * __user *)
(buffer+4))))
-               return -EFAULT;
-   }
    return sys_select(n, inp, outp, exp, tvp);
 }
 #endif

Tested on PPC32. Works fine with provided testcase.

Thanks,
Halesh