From: ebiederm@xmission.com (Eric W. Biederman)
To: Dave Young <dyoung@redhat.com>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] kexec: do not call kmsg_dump in crashdump
Date: Mon, 28 Nov 2011 14:27:02 -0800 [thread overview]
Message-ID: <m1aa7fq3wp.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <20111125081959.GA2505@darkstar.nay.redhat.com> (Dave Young's message of "Fri, 25 Nov 2011 16:19:59 +0800")
Dave Young <dyoung@redhat.com> writes:
> mtd/ram oops dumper will make more functions envolved. In case crash kexec,
> we should avoid kmsg dumper to ensure crashdump success.
>
> kill kmsg_dump callback while crash dumping
Agreed.
There is a similar? Or possibly the same patch already queued in
Andrews tree.
Eric
>
> Signed-off-by: Dave Young <dyoung@redhat.com>
> ---
> kernel/kexec.c | 2 --
> 1 file changed, 2 deletions(-)
>
> --- linux-2.6.orig/kernel/kexec.c 2011-11-18 16:34:18.000000000 +0800
> +++ linux-2.6/kernel/kexec.c 2011-11-24 16:05:08.138660500 +0800
> @@ -1094,8 +1094,6 @@ void crash_kexec(struct pt_regs *regs)
> if (kexec_crash_image) {
> struct pt_regs fixed_regs;
>
> - kmsg_dump(KMSG_DUMP_KEXEC);
> -
> crash_setup_regs(&fixed_regs, regs);
> crash_save_vmcoreinfo();
> machine_crash_shutdown(&fixed_regs);
next prev parent reply other threads:[~2011-11-28 22:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 8:19 [PATCH] kexec: do not call kmsg_dump in crashdump Dave Young
2011-11-25 9:32 ` Cong Wang
2011-11-25 10:03 ` Dave Young
2011-11-28 22:27 ` Eric W. Biederman [this message]
2011-11-28 22:34 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1aa7fq3wp.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox