From: Dave Young <dyoung@redhat.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: ebiederm@xmission.com, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kexec: do not call kmsg_dump in crashdump
Date: Fri, 25 Nov 2011 18:03:56 +0800 [thread overview]
Message-ID: <4ECF680C.7060606@redhat.com> (raw)
In-Reply-To: <CAM_iQpW7WXeUihgbJneJUJ1GAMzXfONfV69dpqeRbUt_781M=Q@mail.gmail.com>
On 11/25/2011 05:32 PM, Cong Wang wrote:
> On Fri, Nov 25, 2011 at 4:19 PM, Dave Young <dyoung@redhat.com> wrote:
>> mtd/ram oops dumper will make more functions envolved. In case crash kexec,
>> we should avoid kmsg dumper to ensure crashdump success.
>>
>> kill kmsg_dump callback while crash dumping
>
> https://lkml.org/lkml/2011/2/1/33
Thanks for give the link. So it's intend to be that.
I'm still confused with the KMSG_DUMP_KEXEC.
crash_kexec()
kmsg_dump(KMSG_DUMP_KEXEC)
kmsg_dump(KMSG_DUMP_PANIC)
Looks like it's equal to original logic, isn't it?
kmsg_dump(anything);
crash_kexec()
So why intruduce KMSG_DUMP_KEXEC? why not just kmsg_dump before crash_kexec?
thoughts?
--
Thanks
Dave
next prev parent reply other threads:[~2011-11-25 10:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 8:19 [PATCH] kexec: do not call kmsg_dump in crashdump Dave Young
2011-11-25 9:32 ` Cong Wang
2011-11-25 10:03 ` Dave Young [this message]
2011-11-28 22:27 ` Eric W. Biederman
2011-11-28 22:34 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECF680C.7060606@redhat.com \
--to=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox