From: ebiederm@xmission.com (Eric W. Biederman)
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@suse.de>, Chris Wright <chrisw@sous-sol.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Zachary Amsden <zach@vmware.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lguest: don't use paravirt_probe, it's dying
Date: Sun, 06 May 2007 19:53:09 -0600 [thread overview]
Message-ID: <m1bqgxmmbe.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <1178363923.12284.164.camel@localhost.localdomain> (Rusty Russell's message of "Sat, 05 May 2007 21:18:43 +1000")
Rusty Russell <rusty@rustcorp.com.au> writes:
> On Sat, 2007-05-05 at 13:22 +1000, Rusty Russell wrote:
>> On Fri, 2007-05-04 at 20:53 -0600, Eric W. Biederman wrote:
>> > Frankly I think the least risk of problems comes from just doing a
>> > separate entry point for lguest for now. It means we don't even have
>> > to touch the common code path and later dropping will be trivially
>> > lguest specific, and certain to not break anything else.
>>
>> Hmm, I railed for so long against Xen doing that, it feels... wrong...
>> to do that now 8)
>
> And here's the patch. It's pretty trivial actually. It even worked
> first time. It applies against -mm (ie. before the "boot with P=V"
> patches I showed before).
>
> Thanks!
> Rusty.
> ==
Looks fine to me. I'm not thrilled about grepping for a know ascii
string in the kernel binary, to find the lguest entry point. But it
is simple, and it's temporary so it looks fine.
It clearly keeps us from having problems on the traditional x86 entry
point.
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Eric
next prev parent reply other threads:[~2007-05-07 1:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 11:56 [PATCH] Revert "[PATCH] paravirt: Add startup infrastructure for paravirtualization" Eric W. Biederman
2007-05-04 12:12 ` Rusty Russell
2007-05-04 14:13 ` Eric W. Biederman
2007-05-04 14:37 ` Rusty Russell
2007-05-04 15:07 ` Eric W. Biederman
2007-05-05 1:22 ` Rusty Russell
2007-05-05 2:45 ` David Miller
2007-05-05 3:14 ` Eric W. Biederman
2007-05-05 3:50 ` David Miller
2007-05-05 2:53 ` Eric W. Biederman
2007-05-05 3:22 ` Rusty Russell
2007-05-05 11:18 ` [PATCH] lguest: don't use paravirt_probe, it's dying Rusty Russell
2007-05-07 1:53 ` Eric W. Biederman [this message]
2007-05-04 15:58 ` [PATCH] Revert "[PATCH] paravirt: Add startup infrastructure for paravirtualization" Andrew Morton
2007-05-05 1:55 ` Rusty Russell
2007-05-04 14:59 ` Jeremy Fitzhardinge
2007-05-04 15:20 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1bqgxmmbe.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox