From: Rusty Russell <rusty@rustcorp.com.au>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@suse.de>, Chris Wright <chrisw@sous-sol.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Zachary Amsden <zach@vmware.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "[PATCH] paravirt: Add startup infrastructure for paravirtualization"
Date: Sat, 05 May 2007 13:22:21 +1000 [thread overview]
Message-ID: <1178335341.12284.99.camel@localhost.localdomain> (raw)
In-Reply-To: <m18xc4nfqf.fsf@ebiederm.dsl.xmission.com>
On Fri, 2007-05-04 at 20:53 -0600, Eric W. Biederman wrote:
> Rusty Russell <rusty@rustcorp.com.au> writes:
> The delicate part right now is that lguest is attempting to use the
> standard kernel entry point which does have a fixed ABI.
>
> If lguest uses that entry point in a hard to maintain way it provides
> a bad example, and it potentially leads to other problems. So I
> really don't want to see the bad example happen, especially if the
> code in the bad example is as general as it is today.
I completely agree, a bad example is worse than no example. Plus, an
opportunity to have you and hpa hacking on lguest is not to be missed.
> Frankly I think the least risk of problems comes from just doing a
> separate entry point for lguest for now. It means we don't even have
> to touch the common code path and later dropping will be trivially
> lguest specific, and certain to not break anything else.
Hmm, I railed for so long against Xen doing that, it feels... wrong...
to do that now 8)
I think I'll need to hack in a magic signature before the lguest start:
it's the only way it'll work with unpacking bzImages as well. And it'll
be trivial to rip out later when we have the Right Way.
I'll spin a patch this afternoon (got to go to puppy training now).
Thanks!
Rusty.
next prev parent reply other threads:[~2007-05-05 3:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 11:56 [PATCH] Revert "[PATCH] paravirt: Add startup infrastructure for paravirtualization" Eric W. Biederman
2007-05-04 12:12 ` Rusty Russell
2007-05-04 14:13 ` Eric W. Biederman
2007-05-04 14:37 ` Rusty Russell
2007-05-04 15:07 ` Eric W. Biederman
2007-05-05 1:22 ` Rusty Russell
2007-05-05 2:45 ` David Miller
2007-05-05 3:14 ` Eric W. Biederman
2007-05-05 3:50 ` David Miller
2007-05-05 2:53 ` Eric W. Biederman
2007-05-05 3:22 ` Rusty Russell [this message]
2007-05-05 11:18 ` [PATCH] lguest: don't use paravirt_probe, it's dying Rusty Russell
2007-05-07 1:53 ` Eric W. Biederman
2007-05-04 15:58 ` [PATCH] Revert "[PATCH] paravirt: Add startup infrastructure for paravirtualization" Andrew Morton
2007-05-05 1:55 ` Rusty Russell
2007-05-04 14:59 ` Jeremy Fitzhardinge
2007-05-04 15:20 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178335341.12284.99.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox