From: ebiederm@xmission.com (Eric W. Biederman)
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Davide Libenzi <davidel@xmailserver.org>,
Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Robin Holt <holt@sgi.com>, Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [RFC, PATCH 1/3] introduce SYS_CLONE_MASK
Date: Sun, 08 Apr 2007 10:19:48 -0600 [thread overview]
Message-ID: <m1lkh23kkb.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20070408155337.GA126@tv-sign.ru> (Oleg Nesterov's message of "Sun, 8 Apr 2007 19:53:37 +0400")
Oleg Nesterov <oleg@tv-sign.ru> writes:
> For review only.
>
> To implement for-in-kerenl-use-only CLONE_ flags, we need to filter out them
> in sys_clone().
Nack
The current clone_flags field is for user space consumption and we
have proposed users for all or almost all of the remaining bits.
If we are going to have kernel only flags please use an additional
argument to do_fork and copy_process.
Your current scheme also has the bad side that if user space supplied
a kernel flag it is hard to detect it and return -EINVAL. Which
limits future expansion. Silently dropping clone flags is a real
pain, if you are trying to detect if a new flag has been implemented.
Eric
next prev parent reply other threads:[~2007-04-08 16:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-08 15:53 [RFC, PATCH 1/3] introduce SYS_CLONE_MASK Oleg Nesterov
2007-04-08 16:19 ` Eric W. Biederman [this message]
2007-04-08 16:57 ` Oleg Nesterov
2007-04-09 1:05 ` Eric W. Biederman
2007-04-09 2:06 ` Roland McGrath
2007-04-09 16:20 ` Eric W. Biederman
2007-04-09 17:30 ` Robin Holt
2007-04-10 0:35 ` Eric W. Biederman
2007-04-10 9:56 ` Robin Holt
2007-04-09 9:06 ` Oleg Nesterov
2007-04-09 10:43 ` Robin Holt
2007-04-09 14:36 ` Eric W. Biederman
2007-04-09 14:52 ` Robin Holt
2007-04-10 15:47 ` Jan Engelhardt
2007-04-10 18:20 ` Jan Engelhardt
-- strict thread matches above, loose matches on Subject: below --
2007-05-29 2:59 Albert Cahalan
2007-05-29 4:57 ` Eric W. Biederman
2007-05-29 3:23 Albert Cahalan
2007-05-29 4:53 ` Eric W. Biederman
2007-05-29 5:56 ` Roland McGrath
2007-05-30 0:33 ` Albert Cahalan
2007-05-30 1:43 ` Eric W. Biederman
2007-07-26 7:34 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1lkh23kkb.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=davidel@xmailserver.org \
--cc=holt@sgi.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
--cc=roland@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox