public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Ingo Molnar <mingo@elte.hu>
Cc: Albert Cahalan <acahalan@gmail.com>,
	Guillaume Chazarain <guichaz@yahoo.fr>,
	akpm@linux-foundation.org, mm-commits@vger.kernel.org,
	oleg@tv-sign.ru, rjw@sisk.pl, roland@redhat.com,
	xemul@openvz.org, linux-kernel <linux-kernel@vger.kernel.org>,
	Ulrich Drepper <drepper@redhat.com>
Subject: Re: + proc-fix-the-threaded-proc-self.patch added to -mm tree
Date: Wed, 28 Nov 2007 04:31:53 -0700	[thread overview]
Message-ID: <m1ve7mehcm.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20071128104622.GB19694@elte.hu> (Ingo Molnar's message of "Wed, 28 Nov 2007 11:46:22 +0100")

Ingo Molnar <mingo@elte.hu> writes:

> * Albert Cahalan <acahalan@gmail.com> wrote:
>
>> On Nov 27, 2007 7:49 PM, Guillaume Chazarain <guichaz@yahoo.fr> wrote:
>> > akpm@linux-foundation.org wrote:
>> >
>> > > We may be stuck with the current broken behavior for backwards
>> > > compatibility reasons but lets try fixing our ancient bug for the 2.6.25
>> > > time frame and see if anyone screams.
>> 
>> It's not broken. It's just not the feature you're looking for.
>
> well it's quite broken at the moment and we are looking for solutions 
> not for a blame game :-) You might have read the thread where i describe 
> what i had to go through to do something fairly trivial.

Yes.

In a lot of ways if you access /proc/self and you get back information
that does not correspond to yourself the result is nonsense.  Which
is a fairly mighty problem.

I'm still trying to understand which will break user space more,
adding /proc/task or changing /proc/self.

>> This one is probably best:
>> /proc/task -> 123/task/456
>> (with both numbers showing)
>
> this sounds good to me. If it's a symlink then there's not much other 
> choice because the thread PIDs do not even show up under /proc anymore.

The name sounds good to me.

I am not certain the two components make sense as we have a possible
permission problem where it is remotely possible that a task will
have permission to access /proc/<tid> but not /proc/<tgid>.

We certainly need to think through that case before making it
to a stable kernel.

The reason I care is that we need to fix /proc/mounts.  So once we
have /proc/task we can also have change /proc/mounts to
be a symlink to /proc/task/mounts. 

Once we get the /proc/mounts thing sorted out.  There are several
other entries in /proc that need to that need to follow in it's wake
as they also become per namespace.  /proc/net and /proc/sysvipc for
starters.

Eric

  reply	other threads:[~2007-11-28 11:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200711262339.lAQNdNrw029057@imap1.linux-foundation.org>
     [not found] ` <20071128014901.4b303954@inria.fr>
2007-11-28  9:41   ` + proc-fix-the-threaded-proc-self.patch added to -mm tree Albert Cahalan
2007-11-28 10:46     ` Ingo Molnar
2007-11-28 11:31       ` Eric W. Biederman [this message]
2007-11-28 11:42         ` Eric W. Biederman
2007-11-28 17:47         ` Albert Cahalan
2007-11-29 21:40           ` Eric W. Biederman
2007-11-30  0:10             ` Ingo Molnar
2007-11-30  7:44             ` Albert Cahalan
2007-12-02  4:00               ` Eric W. Biederman
2007-11-28 18:14       ` Albert Cahalan
2007-11-29 12:34         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1ve7mehcm.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=acahalan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=drepper@redhat.com \
    --cc=guichaz@yahoo.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mm-commits@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --cc=rjw@sisk.pl \
    --cc=roland@redhat.com \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox