From: ebiederm@xmission.com (Eric W. Biederman)
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] make fs/proc/base.c:proc_pid_instantiate() static
Date: Mon, 20 Nov 2006 11:33:59 -0700 [thread overview]
Message-ID: <m1zmamufvs.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20061120022422.GQ31879@stusta.de> (Adrian Bunk's message of "Mon, 20 Nov 2006 03:24:22 +0100")
Adrian Bunk <bunk@stusta.de> writes:
> This patch makes the needlessly global proc_pid_instantiate() static.
Looks good to me.
Acked-by: Eric W. Biederman <ebiederm@xmission.com>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.19-rc5-mm2/fs/proc/base.c.old 2006-11-20 02:08:33.000000000 +0100
> +++ linux-2.6.19-rc5-mm2/fs/proc/base.c 2006-11-20 02:08:47.000000000 +0100
> @@ -1946,8 +1946,9 @@
> return;
> }
>
> -struct dentry *proc_pid_instantiate(struct inode *dir,
> - struct dentry * dentry, struct task_struct *task, void *ptr)
> +static struct dentry *proc_pid_instantiate(struct inode *dir,
> + struct dentry * dentry,
> + struct task_struct *task, void *ptr)
> {
> struct dentry *error = ERR_PTR(-ENOENT);
> struct inode *inode;
prev parent reply other threads:[~2006-11-20 18:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-20 2:24 [2.6 patch] make fs/proc/base.c:proc_pid_instantiate() static Adrian Bunk
2006-11-20 18:33 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1zmamufvs.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox