public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [2.6 patch] make fs/proc/base.c:proc_pid_instantiate() static
@ 2006-11-20  2:24 Adrian Bunk
  2006-11-20 18:33 ` Eric W. Biederman
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2006-11-20  2:24 UTC (permalink / raw)
  To: Eric W. Biederman; +Cc: linux-kernel

This patch makes the needlessly global proc_pid_instantiate() static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.19-rc5-mm2/fs/proc/base.c.old	2006-11-20 02:08:33.000000000 +0100
+++ linux-2.6.19-rc5-mm2/fs/proc/base.c	2006-11-20 02:08:47.000000000 +0100
@@ -1946,8 +1946,9 @@
 	return;
 }
 
-struct dentry *proc_pid_instantiate(struct inode *dir,
-	struct dentry * dentry, struct task_struct *task, void *ptr)
+static struct dentry *proc_pid_instantiate(struct inode *dir,
+					   struct dentry * dentry,
+					   struct task_struct *task, void *ptr)
 {
 	struct dentry *error = ERR_PTR(-ENOENT);
 	struct inode *inode;


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [2.6 patch] make fs/proc/base.c:proc_pid_instantiate() static
  2006-11-20  2:24 [2.6 patch] make fs/proc/base.c:proc_pid_instantiate() static Adrian Bunk
@ 2006-11-20 18:33 ` Eric W. Biederman
  0 siblings, 0 replies; 2+ messages in thread
From: Eric W. Biederman @ 2006-11-20 18:33 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: linux-kernel

Adrian Bunk <bunk@stusta.de> writes:

> This patch makes the needlessly global proc_pid_instantiate() static.

Looks good to me.

Acked-by: Eric W. Biederman <ebiederm@xmission.com>

> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.19-rc5-mm2/fs/proc/base.c.old 2006-11-20 02:08:33.000000000 +0100
> +++ linux-2.6.19-rc5-mm2/fs/proc/base.c	2006-11-20 02:08:47.000000000 +0100
> @@ -1946,8 +1946,9 @@
>  	return;
>  }
>  
> -struct dentry *proc_pid_instantiate(struct inode *dir,
> -	struct dentry * dentry, struct task_struct *task, void *ptr)
> +static struct dentry *proc_pid_instantiate(struct inode *dir,
> +					   struct dentry * dentry,
> +					   struct task_struct *task, void *ptr)
>  {
>  	struct dentry *error = ERR_PTR(-ENOENT);
>  	struct inode *inode;

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-11-20 18:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-20  2:24 [2.6 patch] make fs/proc/base.c:proc_pid_instantiate() static Adrian Bunk
2006-11-20 18:33 ` Eric W. Biederman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox