The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Mikko Perttunen <mperttunen@nvidia.com>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Thierry Reding <thierry.reding@kernel.org>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Svyatoslav Ryhel <clamor95@gmail.com>,
	Svyatoslav Ryhel <clamor95@gmail.com>
Cc: devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 05/10] ARM: tegra: tf701t: Add thermal zones for nct1008 sensor
Date: Thu, 30 Jul 2026 16:07:27 +0900	[thread overview]
Message-ID: <nNMjoMjdT-Guv3By3VWZWw@nvidia.com> (raw)
In-Reply-To: <20260721101059.451699-6-clamor95@gmail.com>

On Tuesday, July 21, 2026 7:10 PM Svyatoslav Ryhel wrote:
> ASUS TF701T has an additional thermal sensor for more accurate readings.
> Add thermal zones for this sensor.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>  .../boot/dts/nvidia/tegra114-asus-tf701t.dts  | 83 +++++++++++++++++++
>  1 file changed, 83 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> index a27d3c4f2c63c..83f8dd84d28a2 100644
> --- a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> +++ b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> @@ -4,6 +4,7 @@
>  
>  #include <dt-bindings/input/gpio-keys.h>
>  #include <dt-bindings/input/input.h>
> +#include <dt-bindings/thermal/thermal.h>
>  
>  #include "tegra114.dtsi"
>  
> @@ -2682,4 +2683,86 @@ vdd_1v8_touch: regulator-touch-vio {
>  		enable-active-high;
>  		vin-supply = <&vdd_3v3_sys>;
>  	};
> +
> +	thermal-zones {
> +		/*
> +		 * NCT72 has two sensors:
> +		 *
> +		 *	0: internal that monitors ambient/skin temperature
> +		 *	1: external that is connected to the CPU's diode
> +		 *
> +		 * Ideally we should use userspace thermal governor,
> +		 * but it's a much more complex solution. The "skin"
> +		 * zone exists as a simpler solution which prevents
> +		 * Transformer from getting too hot from a user's
> +		 * tactile perspective. The CPU zone is intended to
> +		 * protect silicon from damage.
> +		 */
> +
> +		nct72-skin-thermal {
> +			polling-delay-passive = <1000>; /* milliseconds */
> +			polling-delay = <5000>; /* milliseconds */
> +
> +			thermal-sensors = <&temp_sensor 0>;
> +
> +			trips {
> +				skin_alert_trip: skin-alert {
> +					/* throttle at 57C until temperature drops to 56.5C */
> +					temperature = <57000>;
> +					hysteresis = <500>;
> +					type = "passive";
> +				};
> +
> +				skin-crit {
> +					/* shut down at 65C */
> +					temperature = <65000>;
> +					hysteresis = <2000>;
> +					type = "critical";
> +				};
> +			};
> +
> +			cooling-maps {
> +				map-skin {
> +					trip = <&skin_alert_trip>;
> +					cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +							 <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +							 <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +							 <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> +				};
> +			};
> +		};
> +
> +		nct72-cpu-thermal {
> +			polling-delay-passive = <1000>; /* milliseconds */
> +			polling-delay = <5000>; /* milliseconds */
> +
> +			thermal-sensors = <&temp_sensor 1>;
> +
> +			trips {
> +				cpu_alert_trip: cpu-alert {
> +					/* throttle at 75C until temperature drops to 74.5C */
> +					temperature = <75000>;
> +					hysteresis = <500>;
> +					type = "passive";
> +				};
> +
> +				cpu-crit {
> +					/* shut down at 105C */
> +					temperature = <105000>;
> +					hysteresis = <2000>;
> +					type = "critical";
> +				};
> +			};
> +
> +			cooling-maps {
> +				map-cpu {
> +					trip = <&cpu_alert_trip>;
> +					cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +							 <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +							 <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +							 <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> +				};
> +			};
> +		};
> +	};
>  };
> -- 
> 2.53.0
> 
> 

Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>




  reply	other threads:[~2026-07-30  7:07 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21 10:10 [PATCH v2 00/10] ARM: tegra: tf701t: Add new features Svyatoslav Ryhel
2026-07-21 10:10 ` [PATCH v2 01/10] ARM: tegra: tf701t: Configure CPU DFLL clock node Svyatoslav Ryhel
2026-07-30  6:48   ` Mikko Perttunen
2026-07-21 10:10 ` [PATCH v2 02/10] ARM: tegra: tf701t: Add core-supply to PMC node Svyatoslav Ryhel
2026-07-30  6:48   ` Mikko Perttunen
2026-07-21 10:10 ` [PATCH v2 03/10] ARM: tegra: tf701t: Add MC and EMC timing nodes Svyatoslav Ryhel
2026-07-30  6:50   ` Mikko Perttunen
2026-07-21 10:10 ` [PATCH v2 04/10] ARM: tegra: tf701t: Remove pin_ prefix from PMIC pinmux Svyatoslav Ryhel
2026-07-30  7:00   ` Mikko Perttunen
2026-07-21 10:10 ` [PATCH v2 05/10] ARM: tegra: tf701t: Add thermal zones for nct1008 sensor Svyatoslav Ryhel
2026-07-30  7:07   ` Mikko Perttunen [this message]
2026-07-21 10:10 ` [PATCH v2 06/10] ARM: tegra: tf701t: Tune MMC devices Svyatoslav Ryhel
2026-07-28 12:09   ` Mikko Perttunen
2026-07-28 14:17     ` Svyatoslav Ryhel
2026-07-30  7:53       ` Mikko Perttunen
2026-07-21 10:10 ` [PATCH v2 07/10] ARM: tegra: tf701t: Fix BCM43341 WiFi/BT chip configuration Svyatoslav Ryhel
2026-07-28 12:13   ` Mikko Perttunen
2026-07-28 14:08     ` Svyatoslav Ryhel
2026-07-29 10:27       ` Thierry Reding
2026-07-29 12:10         ` Svyatoslav Ryhel
2026-07-21 10:10 ` [PATCH v2 08/10] ARM: tegra: tf701t: Complete power sensor node Svyatoslav Ryhel
2026-07-30  7:19   ` Mikko Perttunen
2026-07-21 10:10 ` [PATCH v2 09/10] ARM: tegra: tf701t: Configure UART-B line used for GPS Svyatoslav Ryhel
2026-07-30  8:03   ` Mikko Perttunen
2026-07-21 10:10 ` [PATCH v2 10/10] ARM: tegra: tf701t: Add chosen node Svyatoslav Ryhel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nNMjoMjdT-Guv3By3VWZWw@nvidia.com \
    --to=mperttunen@nvidia.com \
    --cc=clamor95@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=thierry.reding@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox