From: Takashi Iwai <tiwai@suse.de>
To: Miles Chen <miles.chen@mediatek.com>
Cc: <alsa-devel@alsa-project.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <matthias.bgg@gmail.com>,
<perex@perex.cz>, <rdunlap@infradead.org>, <tiwai@suse.com>
Subject: Re: [PATCH -next V2] sound/oss/dmasound: fix 'dmasound_setup' defined but not used
Date: Fri, 22 Apr 2022 07:58:38 +0200 [thread overview]
Message-ID: <s5h35i5veup.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220422025312.7718-1-miles.chen@mediatek.com>
On Fri, 22 Apr 2022 04:53:12 +0200,
Miles Chen wrote:
>
> Hi Taksshi,
>
> >> We observed: 'dmasound_setup' defined but not used error with
> >> COMPILER=gcc ARCH=m68k DEFCONFIG=allmodconfig build.
> >>
> >> Fix it by adding __maybe_unused to dmasound_setup.
> >>
> >> Error(s):
> >> sound/oss/dmasound/dmasound_core.c:1431:12: error: 'dmasound_setup' defined but not used [-Werror=unused-function]
> >>
> >> Fixes: 9dd7c46346ca ("sound/oss/dmasound: fix build when drivers are mixed =y/=m")
> >> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
> >> Cc: Takashi Iwai <tiwai@suse.com>
> >
> >Thanks, applied.
>
> This patch is needed in 5.18-rc3 [1] too, should I submit another patch or
> you can pick it to the mainstream?
It's included in the branch for the next PR to 5.18.
thanks,
Takashi
prev parent reply other threads:[~2022-04-22 5:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 9:19 [PATCH -next V2] sound/oss/dmasound: fix 'dmasound_setup' defined but not used Miles Chen
2022-04-15 0:01 ` Randy Dunlap
2022-04-15 7:17 ` Takashi Iwai
2022-04-22 2:53 ` Miles Chen
2022-04-22 5:58 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h35i5veup.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=miles.chen@mediatek.com \
--cc=perex@perex.cz \
--cc=rdunlap@infradead.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox