The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Jaroslav Kysela <perex@perex.cz>,
	Eliot Blennerhassett <eblennerhassett@audioscience.com>
Subject: Re: [PATCH] hpimsgx: fix wrong sizeof
Date: Wed, 28 Jul 2010 11:54:01 +0200	[thread overview]
Message-ID: <s5h6300vsna.wl%tiwai@suse.de> (raw)
In-Reply-To: <1280307522.28099.1.camel@mola>

At Wed, 28 Jul 2010 16:58:42 +0800,
Axel Lin wrote:
> 
> The correct size should be sizeof(gRESP_HPI_SUBSYS_FIND_ADAPTERS),
> sizeof(&gRESP_HPI_SUBSYS_FIND_ADAPTERS) is incorrect.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Applied now.  Thanks.


Takashi

> ---
>  sound/pci/asihpi/hpimsgx.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/pci/asihpi/hpimsgx.c b/sound/pci/asihpi/hpimsgx.c
> index 2ee90dc..f01ab96 100644
> --- a/sound/pci/asihpi/hpimsgx.c
> +++ b/sound/pci/asihpi/hpimsgx.c
> @@ -741,7 +741,7 @@ static void HPIMSGX__reset(u16 adapter_index)
>  		hpi_init_response(&hr, HPI_OBJ_SUBSYSTEM,
>  			HPI_SUBSYS_FIND_ADAPTERS, 0);
>  		memcpy(&gRESP_HPI_SUBSYS_FIND_ADAPTERS, &hr,
> -			sizeof(&gRESP_HPI_SUBSYS_FIND_ADAPTERS));
> +			sizeof(gRESP_HPI_SUBSYS_FIND_ADAPTERS));
>  
>  		for (adapter = 0; adapter < HPI_MAX_ADAPTERS; adapter++) {
>  
> -- 
> 1.5.4.3
> 
> 
> 

      reply	other threads:[~2010-07-28  9:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-28  8:58 [PATCH] hpimsgx: fix wrong sizeof Axel Lin
2010-07-28  9:54 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h6300vsna.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=axel.lin@gmail.com \
    --cc=eblennerhassett@audioscience.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox