public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Nicolas Huaman" <nicolas@herochao.de>
Cc: "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: update quirk for B&W PX to remove microphone
Date: Thu, 04 Oct 2018 22:55:46 +0200	[thread overview]
Message-ID: <s5h7eixl9d9.wl-tiwai@suse.de> (raw)
In-Reply-To: <20181004144205.18153-1-nicolas@herochao.de>

On Thu, 04 Oct 2018 16:42:05 +0200,
Nicolas Huaman wrote:
> 
> A quirk in snd-usb-audio was added to automate setting sample rate to
> 4800k and remove the previously exposed nonfunctional microphone for 
> the Bowers & Wilkins PX:
> commit 240a8af929c7c57dcde28682725b29cf8474e8e5
> https://lore.kernel.org/patchwork/patch/919689/
> 
> However the headphones where updated shortly after that to remove the
> unintentional microphone functionality. I guess because of this the
> headphones now crash when connecting them via USB while the quirk is
> active. Dmesg:
> 
> snd-usb-audio: probe of 2-3:1.0 failed with error -22
> usb 2-3: 2:1: cannot get min/max values for control 2 (id 2)
> 
> This patch removes the microfone and allows the headphones to connect 
> and work out of the box. It is based on the current mainline kernel 
>  and successfully applied an tested on my machine (4.18.10.arch1-1).
> 
> Signed-off-by: Nicolas Huaman <nicolas@herochao.de>

Thanks, that looks much better now, and I can apply it.

But just to be sure: is any quirk required after the firmware update
on this device at all?  What happens if you remove the whole quirk?

If this modified quirk is still mandatory, I'll happily apply the
patch.


thanks,

Takashi

  reply	other threads:[~2018-10-04 20:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 14:42 [PATCH] ALSA: usb-audio: update quirk for B&W PX to remove microphone Nicolas Huaman
2018-10-04 20:55 ` Takashi Iwai [this message]
2018-10-04 22:31   ` Nicolas Herochao
2018-10-05  7:14     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h7eixl9d9.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas@herochao.de \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox