* [PATCH] ALSA: sgio2audio: Remove usage of dropped hw_params/hw_free functions
@ 2020-03-06 10:58 Thomas Bogendoerfer
2020-03-06 11:08 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Bogendoerfer @ 2020-03-06 10:58 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel
Commit ee88f4ebe575 ("ALSA: mips: Use managed buffer allocation") removed
superfluous hw_params/hw_free callbacks, but forgot to remove them where
they were used.
Fixes: ee88f4ebe575 ("ALSA: mips: Use managed buffer allocation")
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
---
sound/mips/sgio2audio.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/sound/mips/sgio2audio.c b/sound/mips/sgio2audio.c
index 9f60a5037f8b..5bf1ea150f26 100644
--- a/sound/mips/sgio2audio.c
+++ b/sound/mips/sgio2audio.c
@@ -649,8 +649,6 @@ snd_sgio2audio_pcm_pointer(struct snd_pcm_substream *substream)
static const struct snd_pcm_ops snd_sgio2audio_playback1_ops = {
.open = snd_sgio2audio_playback1_open,
.close = snd_sgio2audio_pcm_close,
- .hw_params = snd_sgio2audio_pcm_hw_params,
- .hw_free = snd_sgio2audio_pcm_hw_free,
.prepare = snd_sgio2audio_pcm_prepare,
.trigger = snd_sgio2audio_pcm_trigger,
.pointer = snd_sgio2audio_pcm_pointer,
@@ -659,8 +657,6 @@ static const struct snd_pcm_ops snd_sgio2audio_playback1_ops = {
static const struct snd_pcm_ops snd_sgio2audio_playback2_ops = {
.open = snd_sgio2audio_playback2_open,
.close = snd_sgio2audio_pcm_close,
- .hw_params = snd_sgio2audio_pcm_hw_params,
- .hw_free = snd_sgio2audio_pcm_hw_free,
.prepare = snd_sgio2audio_pcm_prepare,
.trigger = snd_sgio2audio_pcm_trigger,
.pointer = snd_sgio2audio_pcm_pointer,
@@ -669,8 +665,6 @@ static const struct snd_pcm_ops snd_sgio2audio_playback2_ops = {
static const struct snd_pcm_ops snd_sgio2audio_capture_ops = {
.open = snd_sgio2audio_capture_open,
.close = snd_sgio2audio_pcm_close,
- .hw_params = snd_sgio2audio_pcm_hw_params,
- .hw_free = snd_sgio2audio_pcm_hw_free,
.prepare = snd_sgio2audio_pcm_prepare,
.trigger = snd_sgio2audio_pcm_trigger,
.pointer = snd_sgio2audio_pcm_pointer,
--
2.25.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: sgio2audio: Remove usage of dropped hw_params/hw_free functions
2020-03-06 10:58 [PATCH] ALSA: sgio2audio: Remove usage of dropped hw_params/hw_free functions Thomas Bogendoerfer
@ 2020-03-06 11:08 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2020-03-06 11:08 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel
On Fri, 06 Mar 2020 11:58:37 +0100,
Thomas Bogendoerfer wrote:
>
> Commit ee88f4ebe575 ("ALSA: mips: Use managed buffer allocation") removed
> superfluous hw_params/hw_free callbacks, but forgot to remove them where
> they were used.
>
> Fixes: ee88f4ebe575 ("ALSA: mips: Use managed buffer allocation")
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Doh, sorry for the mess. Applied now.
thanks,
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-06 11:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-06 10:58 [PATCH] ALSA: sgio2audio: Remove usage of dropped hw_params/hw_free functions Thomas Bogendoerfer
2020-03-06 11:08 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox