From: Takashi Iwai <tiwai@suse.de>
To: "Connor McAdams" <conmanx360@gmail.com>
Cc: <alsa-devel@alsa-project.org>,
"Alastair Bridgewater" <alastair.bridgewater@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/11] Add Recon3D support + Driver cleanup
Date: Wed, 08 Aug 2018 20:43:22 +0200 [thread overview]
Message-ID: <s5ha7pwhf79.wl-tiwai@suse.de> (raw)
In-Reply-To: <1533749663-8200-1-git-send-email-conmanx360@gmail.com>
On Wed, 08 Aug 2018 19:34:11 +0200,
Connor McAdams wrote:
>
> This patch series adds support for the Recon3D PCI-E card. I have
> personally tested it on a Recon3D that was sent to me, and included
> that PCI ID in the quirk table.
>
> Much of this patch series renames Recon3Di functions to just r3d
> because both cards behave similarly.
All patches look well cooked. I applied all 11 patches now.
> Aside from that, I do have a question- If the PCI ID's are included in
> the Window's driver .inf file, would I be good to add them in as
> quirks? Or should I wait for someone with the card to test it, and
> then add it once I know it works on that specific card?
Such a decision depends on the situation, and in the case of CA0132,
we can take them, I suppose. The boards don't work properly without
the explicit fixes, so it can't be worse, after all :)
Thanks!
Takashi
prev parent reply other threads:[~2018-08-08 18:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 17:34 [PATCH 00/11] Add Recon3D support + Driver cleanup Connor McAdams
2018-08-08 17:34 ` [PATCH 01/11] ALSA: hda/ca0132 - Create mmio gpio function to make code clearer Connor McAdams
2018-08-08 17:34 ` [PATCH 02/11] ALSA: hda/ca0132 - Clean up ca0132_init function Connor McAdams
2018-08-08 17:34 ` [PATCH 03/11] ALSA: hda/ca0132 - Add alt_functions unsolicited response Connor McAdams
2018-08-08 17:34 ` [PATCH 04/11] ALSA: hda/ca0132 - Add quirk ID and enum for Recon3D Connor McAdams
2018-08-08 17:34 ` [PATCH 05/11] ALSA: hda/ca0132 - Add Recon3D pincfg Connor McAdams
2018-08-08 17:34 ` [PATCH 06/11] ALSA: hda/ca0132 - Add bool variable to enable/disable pci region2 mmio Connor McAdams
2018-08-08 17:34 ` [PATCH 07/11] ALSA: hda/ca0132 - Add Recon3D startup functions and setup Connor McAdams
2018-08-08 17:34 ` [PATCH 08/11] ALSA: hda/ca0132 - Add DSP setup defaults for Recon3D Connor McAdams
2018-08-08 17:34 ` [PATCH 09/11] ALSA: hda/ca0132 - Add Recon3D input and output select commands Connor McAdams
2018-08-08 17:34 ` [PATCH 10/11] ALSA: hda/ca0132 - Change mixer controls for Recon3D Connor McAdams
2018-08-08 17:34 ` [PATCH 11/11] ALSA: hda/ca0132 - Add exit commands " Connor McAdams
2018-08-08 18:43 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5ha7pwhf79.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alastair.bridgewater@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=conmanx360@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox