From: Takashi Iwai <tiwai@suse.de>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH] ALSA: usx2y: Adjust indentation in snd_usX2Y_hwdep_dsp_status
Date: Wed, 18 Dec 2019 07:33:44 +0100 [thread overview]
Message-ID: <s5hbls616t3.wl-tiwai@suse.de> (raw)
In-Reply-To: <20191218034257.54535-1-natechancellor@gmail.com>
On Wed, 18 Dec 2019 04:42:57 +0100,
Nathan Chancellor wrote:
>
> Clang warns:
>
> ../sound/usb/usx2y/usX2Yhwdep.c:122:3: warning: misleading indentation;
> statement is not part of the previous 'if' [-Wmisleading-indentation]
> info->version = USX2Y_DRIVER_VERSION;
> ^
> ../sound/usb/usx2y/usX2Yhwdep.c:120:2: note: previous statement is here
> if (us428->chip_status & USX2Y_STAT_CHIP_INIT)
> ^
> 1 warning generated.
>
> This warning occurs because there is a space before the tab on this
> line. Remove it so that the indentation is consistent with the Linux
> kernel coding style and clang no longer warns.
>
> This was introduced before the beginning of git history so no fixes tag.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/831
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Applied, thanks.
Takashi
prev parent reply other threads:[~2019-12-18 6:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 3:42 [PATCH] ALSA: usx2y: Adjust indentation in snd_usX2Y_hwdep_dsp_status Nathan Chancellor
2019-12-18 6:33 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hbls616t3.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox