public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ALSA: au88x0: pr_* replaced with dev_*
Date: Thu, 09 Oct 2014 15:38:41 +0200	[thread overview]
Message-ID: <s5hd2a1tlb2.wl-tiwai@suse.de> (raw)
In-Reply-To: <1412847397-4292-2-git-send-email-sudipm.mukherjee@gmail.com>

At Thu,  9 Oct 2014 15:06:37 +0530,
Sudip Mukherjee wrote:
> 
> pr_* macros replaced with dev_* as they are more preffered over pr_*.
> each file which had pr_* was reviewed manually and replaced with dev_*.
> here we have actually used the reference of the vortex which was added
> to some functions in the previous patch of this series.
> 
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>  sound/pci/au88x0/au88x0.c        |  26 +++++-----
>  sound/pci/au88x0/au88x0_a3d.c    |  15 +++---
>  sound/pci/au88x0/au88x0_core.c   | 103 ++++++++++++++++++++++-----------------
>  sound/pci/au88x0/au88x0_eq.c     |   3 +-
>  sound/pci/au88x0/au88x0_game.c   |   3 +-
>  sound/pci/au88x0/au88x0_mpu401.c |   2 +-
>  sound/pci/au88x0/au88x0_pcm.c    |   7 +--
>  sound/pci/au88x0/au88x0_synth.c  |  17 ++++---
>  8 files changed, 98 insertions(+), 78 deletions(-)
> 
> diff --git a/sound/pci/au88x0/au88x0.c b/sound/pci/au88x0/au88x0.c
> index 21ce31f..ea66cee 100644
> --- a/sound/pci/au88x0/au88x0.c
> +++ b/sound/pci/au88x0/au88x0.c
> @@ -48,10 +48,10 @@ static void vortex_fix_latency(struct pci_dev *vortex)
>  {
>  	int rc;
>  	if (!(rc = pci_write_config_byte(vortex, 0x40, 0xff))) {
> -			pr_info( CARD_NAME
> +			dev_info(&vortex->dev, CARD_NAME
>  			       ": vortex latency is 0xff\n");

Omit the superfluous prefix when converting to dev_info() & co.
Other than that, looks good to me.


thanks,

Takashi

  reply	other threads:[~2014-10-09 13:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-09  9:36 [PATCH 1/2] ALSA: au88x0: added reference of vortex_t Sudip Mukherjee
2014-10-09  9:36 ` [PATCH 2/2] ALSA: au88x0: pr_* replaced with dev_* Sudip Mukherjee
2014-10-09 13:38   ` Takashi Iwai [this message]
2014-10-09 14:18     ` Joe Perches
2014-10-10  6:17       ` Sudip Mukherjee
2014-10-10  6:20         ` Joe Perches
2014-10-10  6:22         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hd2a1tlb2.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox