* [PATCH] ALSA: echoaudio: remove redundant assignment to variable i
@ 2022-04-05 13:54 Colin Ian King
2022-04-05 16:20 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-04-05 13:54 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, alsa-devel; +Cc: kernel-janitors, linux-kernel
The variable i is being assigned a value that is never read, it
is being re-assigned in the following for-loop. The assignment is
redundant and can be removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
sound/pci/echoaudio/midi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/pci/echoaudio/midi.c b/sound/pci/echoaudio/midi.c
index 7be5c3327b16..47b2c023ee3d 100644
--- a/sound/pci/echoaudio/midi.c
+++ b/sound/pci/echoaudio/midi.c
@@ -124,7 +124,6 @@ static int midi_service_irq(struct echoaudio *chip)
return 0;
/* Get the MIDI data from the comm page */
- i = 1;
received = 0;
for (i = 1; i <= count; i++) {
/* Get the MIDI byte */
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: echoaudio: remove redundant assignment to variable i
2022-04-05 13:54 [PATCH] ALSA: echoaudio: remove redundant assignment to variable i Colin Ian King
@ 2022-04-05 16:20 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2022-04-05 16:20 UTC (permalink / raw)
To: Colin Ian King
Cc: Jaroslav Kysela, Takashi Iwai, alsa-devel, kernel-janitors,
linux-kernel
On Tue, 05 Apr 2022 15:54:12 +0200,
Colin Ian King wrote:
>
> The variable i is being assigned a value that is never read, it
> is being re-assigned in the following for-loop. The assignment is
> redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-06 2:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-05 13:54 [PATCH] ALSA: echoaudio: remove redundant assignment to variable i Colin Ian King
2022-04-05 16:20 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox