public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: "Hanno Böck" <hanno@hboeck.de>,
	alsa-devel@alsa-project.org, perex@perex.cz,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: constify functions in ac97
Date: Wed, 12 Jan 2011 18:02:10 +0100	[thread overview]
Message-ID: <s5hei8i838t.wl%tiwai@suse.de> (raw)
In-Reply-To: <AANLkTi=SJpxh5h774shB+MW=xM8cyfunyJYO0deU9mCT@mail.gmail.com>

At Wed, 12 Jan 2011 14:44:07 +0200,
Alexey Dobriyan wrote:
> 
> On Wed, Jan 12, 2011 at 1:03 PM, Hanno Böck <hanno@hboeck.de> wrote:
> >  struct snd_ac97_build_ops {
> > -       int (*build_3d) (struct snd_ac97 *ac97);
> > -       int (*build_specific) (struct snd_ac97 *ac97);
> > -       int (*build_spdif) (struct snd_ac97 *ac97);
> > -       int (*build_post_spdif) (struct snd_ac97 *ac97);
> > +       int (* const build_3d) (struct snd_ac97 *ac97);
> > +       int (* const build_specific) (struct snd_ac97 *ac97);
> > +       int (* const build_spdif) (struct snd_ac97 *ac97);
> > +       int (* const build_post_spdif) (struct snd_ac97 *ac97);
> >  #ifdef CONFIG_PM
> > -       void (*suspend) (struct snd_ac97 *ac97);
> > -       void (*resume) (struct snd_ac97 *ac97);
> > +       void (* const suspend) (struct snd_ac97 *ac97);
> > +       void (* const resume) (struct snd_ac97 *ac97);
> >  #endif
> > -       void (*update_jacks) (struct snd_ac97 *ac97);   /* for jack-sharing */
> > +       /* for jack-sharing */
> > +       void (* const update_jacks) (struct snd_ac97 *ac97);
> 
> Can we please not do this.
> 
> You made whole ops structure RO, this is enough.

Yes.  Hanno, could you fix and resubmit?


thanks,

Takashi

  reply	other threads:[~2011-01-12 17:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-12 11:03 [PATCH] sound: constify functions in ac97 Hanno Böck
2011-01-12 12:44 ` Alexey Dobriyan
2011-01-12 17:02   ` Takashi Iwai [this message]
2011-01-14 12:32     ` Hanno Böck
2011-01-14 18:20       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hei8i838t.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=adobriyan@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=hanno@hboeck.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox