The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
	<perex@perex.cz>, <tiwai@suse.com>, <broonie@kernel.org>
Subject: Re: [PATCH -next] ALSA: fm801: Fix missing pci_release_regions() on error in snd_fm801_create()
Date: Wed, 16 Jun 2021 08:50:59 +0200	[thread overview]
Message-ID: <s5hfsxi1ewc.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210616025507.2120103-1-yangyingliang@huawei.com>

On Wed, 16 Jun 2021 04:55:07 +0200,
Yang Yingliang wrote:
> 
> Fix the missing pci_release_regions() before return
> from snd_fm801_create() in the error handling case.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

pci_regions() is manated in pcim_release(), hence you don't need to
call it explicitly.


thanks,

Takashi

  reply	other threads:[~2021-06-16  6:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16  2:55 [PATCH -next] ALSA: fm801: Fix missing pci_release_regions() on error in snd_fm801_create() Yang Yingliang
2021-06-16  6:50 ` Takashi Iwai [this message]
2021-06-16  7:02   ` Yang Yingliang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hfsxi1ewc.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=yangyingliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox